Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 268
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 29
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #1031

Closed
Open
Opened 5 months ago by Ben Hayward@benhayward.ben
Report abuse New issue

Moderation queue number incorrect & posts duplicating.

Summary

If you are a moderator of a closed group, when you've approved all of the posts, you will likely see one or two still remaining, that you are unable to approve, as they are not in the queue. You will also see that some posts that you have already approved, are duplicate in the feed, one approved entity, one unapproved, with nothing in the moderation queue.

Steps to reproduce

Requires that you are a group moderator of a closed group.

Platform information

Cross-platform web

What is the current bug behavior?

Queue will show posts awaiting approval that are not

What is the expected correct behavior?

Queue should show empty if there are no posts to approve, furthermore posts should not be getting duplicated.

Relevant logs and/or screenshots

Video at this link https://www.minds.com/newsfeed/999958056778829824

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Edited 2 months ago by Mark Harding

Related issues
0

Related merge requests
1
  • [Sprint/PinkPanther](fix): Refactored logic for moderation queue to not query Cassandra for post count.
    !381
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 4
  • Designs 0
  • Ben Hayward @benhayward.ben added Priority::2 - Normal Product::Groups Type::Bug scoped labels 5 months ago

    added scoped labels

  • Mark Harding @markeharding added Squad::Yellow scoped label 3 months ago

    added scoped label

  • Mark Harding @markeharding added 1 deleted label 3 months ago

    added 1 deleted label

  • Mark Harding @markeharding removed milestone 3 months ago

    removed milestone

  • Ben Hayward @benhayward.ben assigned to @benhayward.ben 3 months ago

    assigned to @benhayward.ben

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label 3 months ago

    added scoped label

  • Ben Hayward @benhayward.ben removed 1 deleted label 3 months ago

    removed 1 deleted label

  • Ben Hayward @benhayward.ben added 1 deleted label 3 months ago

    added 1 deleted label

  • Ben Hayward @benhayward.ben removed Status::InProgress label 3 months ago

    removed label

  • Ben Hayward @benhayward.ben changed time estimate to 5h 3 months ago

    changed time estimate to 5h

  • Ben Hayward @benhayward.ben added 1h 30m of time spent at 2019-09-25 3 months ago

    added 1h 30m of time spent at 2019-09-25

  • Ben Hayward @benhayward.ben changed weight to 2 3 months ago

    changed weight to 2

  • Ben Hayward @benhayward.ben changed milestone to %Misc. Q4 2019 3 months ago

    changed milestone to %Misc. Q4 2019

  • Mark Harding @markeharding added 1 deleted label and removed 1 deleted label 2 months ago

    added 1 deleted label and removed 1 deleted label

  • Mark Harding @markeharding added Status::Backlog scoped label 2 months ago

    added scoped label

  • Mark Harding @markeharding changed title from (bug): Moderation queue number incorrect & posts duplicating. to Moderation queue number incorrect & posts duplicating. 2 months ago

    changed title from Moderation queue number incorrect & posts duplicating. to Moderation queue number incorrect & posts duplicating.

  • Ben Hayward @benhayward.ben mentioned in issue front#239 2 months ago

    mentioned in issue front#239

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Backlog label 2 months ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben removed Status::InProgress label 2 months ago

    removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 months ago
    Developer

    https://gitlab.com/minds/engine/blob/master/Core/Groups/AdminQueue.php#L86

    Is the function that is counting, simply using SELECT COUNT(*) FROM entities_by_time WHERE key = ?;

    This number will return even when there are no activities send along with the number.

  • Ben Hayward @benhayward.ben changed milestone to %Misc. Q4 2019 2 months ago

    changed milestone to %Misc. Q4 2019

  • Ben Hayward @benhayward.ben changed weight to 2 2 months ago

    changed weight to 2

  • Ben Hayward @benhayward.ben moved from minds#688 (moved) 2 months ago

    moved from minds#688 (moved)

  • Ben Hayward @benhayward.ben mentioned in merge request !381 (closed) 2 months ago

    mentioned in merge request !381 (closed)

  • Ben Hayward @benhayward.ben added 1h of time spent at 2019-10-21 2 months ago

    added 1h of time spent at 2019-10-21

  • Ben Hayward @benhayward.ben added Status::Review scoped label 2 months ago

    added scoped label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 7 minutes ago
    Developer

    Still ongoing issues with this.

  • Ben Hayward @benhayward.ben unassigned @benhayward.ben 7 minutes ago

    unassigned @benhayward.ben

  • Ben Hayward @benhayward.ben added Status::Scheduling scoped label and automatically removed Status::Review label 7 minutes ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 6 minutes ago
    Developer

    Ben 20:00 With the moderation queue discrepancies, I dug down, and it seems two near identical calls

    select * from entities_by_time where key = ? select count(*) from entities_by_time where key = ?

    Are seeing different things. top one returns say, 3 entities, but the count returns 5

    Edited by Ben Hayward 6 minutes ago
  • Ben Hayward
    Ben Hayward @benhayward.ben · 5 minutes ago
    Developer

    Ben 13:55 2x ideas to add to the query

    distinct CONSISTENCY ALL As it's taking a stab in the dark with production data, have either of you encountered this issue before? https://stackoverflow.com/questions/33161736/cassandra-cqlsh-giving-wrong-counts

Please register or sign in to reply
0 Assignees
None
none
Epic
None
Misc. Q4 2019
Milestone
Misc. Q4 2019
Time tracking
Spent 1h
Est 5h
None
Due date
None
5
Labels
Priority::2 - Normal Product::Groups Squad::Yellow Status::Scheduling Type::Bug
2
Weight
2
Confidentiality
Not confidential
Lock issue
Unlocked
3
3 participants
user avatar
Ben Hayward
user avatar
Mark Harding
user avatar
Japhy Ryder
Reference: minds/engine#1031