Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 270
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 29
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #311

Closed
Open
Opened 9 months ago by Ben Hayward@benhayward.ben
Report abuse New issue

(feat): Introduce new lightweight app for video player that allows to show in iframe

Summary

Context:

I'm trying to embed Minds videos on my external pages using the minds-supplied code from the Minds "Share" link.

When I try in Chrome I get an empty frame with the text: "www.minds.com refused to connect." Firefox simply gives an empty area the size of the iframe.

Running developer tools on Chrome and looking at the console, I see the following error: Refused to display 'xxxxxx' in a frame because it set 'X-Frame-Options' to 'deny'.

The issue here after discussing with @edgebal seems to be that a recent security change to prevent click-jacking, has broken video embedding.

Steps to reproduce

(How one can reproduce the issue - this is very important)

Platform information

Windows 10, Chrome and Firefox lastest versions

What is the current bug behavior?

Video cannot be embedded

What is the expected correct behavior?

We should ideally find a solution where we can mitigate the risk of click-jacking, whilst also allowing video embedding.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Possible fixes

Mark has mentioned that this could potentially be solved by either splitting the embedded links off onto a subdomain, or we may be able to remove the header for a specific endpoint.

Edited 6 months ago by Mark Harding

Related issues
0

Related merge requests
1
  • [Sprint/InterestingIguana] (feat): embeds site
    embed !1
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 1
  • Designs 0
  • Ben Hayward @benhayward.ben added Type::Bug scoped label 9 months ago

    added scoped label

  • Ben Hayward @benhayward.ben added Priority::2 - Normal Product::Platform scoped labels 9 months ago

    added scoped labels

  • Bill Ottman :dragon_face: @ottman added to epic &15 8 months ago

    added to epic &15

  • Ben Hayward @benhayward.ben changed the description 7 months ago

    changed the description

  • Ben Hayward @benhayward.ben changed milestone to %sprint: Elevated Eagle 7 months ago

    changed milestone to %sprint: Elevated Eagle

  • Mark Harding @markeharding changed milestone to %sprint: Interesting Iguana 6 months ago

    changed milestone to %sprint: Interesting Iguana

  • Mark Harding @markeharding added Type::Feature scoped label and automatically removed Type::Bug label 6 months ago

    added scoped label and automatically removed label

  • Mark Harding @markeharding changed title from (bug): Video embedding broken to (feat): Introduce new lightweight app for video player that allows to show in iframe 6 months ago

    changed title from ( to (

  • Mark Harding @markeharding changed weight to 10 6 months ago

    changed weight to 10

  • Mark Harding @markeharding assigned to @eiennohi 6 months ago

    assigned to @eiennohi

  • Mark Harding @markeharding changed epic to &6 (closed) 6 months ago

    changed epic to &6 (closed)

  • Ben Hayward @benhayward.ben mentioned in issue minds#589 (closed) 6 months ago

    mentioned in issue minds#589 (closed)

  • Marcelo Rivera @eiennohi added Status::InProgress scoped label 5 months ago

    added scoped label

  • Marcelo Rivera @eiennohi added Status::Review scoped label and automatically removed Status::InProgress label 5 months ago

    added scoped label and automatically removed label

  • Marcelo Rivera @eiennohi changed weight to 15 5 months ago

    changed weight to 15

  • Marcelo Rivera @eiennohi mentioned in merge request embed!1 5 months ago

    mentioned in merge request embed!1

  • Mark Harding @markeharding added Squad::Yellow scoped label 5 months ago

    added scoped label

  • Marcelo Rivera @eiennohi added Status::Follow Up scoped label and automatically removed Status::Review label 5 months ago

    added scoped label and automatically removed label

  • Emiliano Balbuena @edgebal removed milestone 5 months ago

    removed milestone

  • Emiliano Balbuena @edgebal removed from epic &6 (closed) 4 months ago

    removed from epic &6 (closed)

  • Ben Hayward
    Ben Hayward @benhayward.ben · 34 minutes ago
    Developer

    @eiennohi can you advise the status of this and close if necessary?

Please register or sign in to reply
Assignee
Marcelo Rivera's avatar
Marcelo Rivera @eiennohi
none
Epic
None
None
Milestone
None
Time tracking
No estimate or time spent
None
Due date
None
5
Labels
Priority::2 - Normal Product::Platform Squad::Yellow Status::Follow Up Type::Feature
15
Weight
15
Confidentiality
Not confidential
Lock issue
Unlocked
5
5 participants
user avatar
Marcelo Rivera
user avatar
Ben Hayward
user avatar
Emiliano Balbuena
user avatar
Mark Harding
user avatar
Bill Ottman
Reference: minds/engine#311