Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 271
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 29
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #965

Closed
Open
Opened 2 months ago by Mark Harding@markeharding
Report abuse New issue

Clean up the unleash client and implement the strategies

  • unleash-client-php!1: This merge request includes all the work done by @brianhatchet, complete with a psr compliant caching interface.
  • unleash-client-php!2 (merged): Clean up and strategies implementation

We want to make it Unleash compliant, but for our purposes we can focus on the gitlab version

https://docs.gitlab.com/ee/user/project/operations/feature_flags.html

Specifically, we need to implement the strategies section

https://docs.gitlab.com/ee/user/project/operations/feature_flags.html#feature-flag-strategies

Edited 6 days ago by Emiliano Balbuena

Related issues
0

Related merge requests
2
  • WIP: Unleash Client
    unleash-client-php !1
    Avatar for Emiliano Balbuena
  • Clean up and strategies
    unleash-client-php !2
    Avatar for Ben Hayward
    Avatar for Brian Hatchet
  • Discussion 4
  • Designs 0
  • Mark Harding @markeharding changed milestone to %Unleash feature toggles 2 months ago

    changed milestone to %Unleash feature toggles

  • Mark Harding @markeharding added 1 deleted label 2 months ago

    added 1 deleted label

  • Mark Harding @markeharding added Priority::2 - Normal Product::Platform Status::Backlog Type::Feature scoped labels 2 months ago

    added scoped labels

  • Mark Harding @markeharding changed weight to 4 2 months ago

    changed weight to 4

  • Mark Harding @markeharding changed the description 2 months ago

    changed the description

  • Brian Hatchet :speech_balloon: @brianhatchet unassigned @brianhatchet 4 weeks ago

    unassigned @brianhatchet

  • Brian Hatchet :speech_balloon: @brianhatchet removed 1 deleted label 4 weeks ago

    removed 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Scheduling scoped label and automatically removed Status::Backlog label 4 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet · 4 weeks ago
    Developer

    Hijacking this one as the remainder of the work to be done card.

  • Brian Hatchet :speech_balloon: @brianhatchet assigned to @edgebal 4 weeks ago

    assigned to @edgebal

  • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Yellow scoped label 4 weeks ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 8 4 weeks ago

    changed weight to 8

  • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label 4 weeks ago

    added 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet changed title from Create PHP SDK for Unleash to Clean up the unleash client and implement the strategies 4 weeks ago

    changed title from C to C

  • Brian Hatchet :speech_balloon: @brianhatchet changed the description 4 weeks ago

    changed the description

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 1d 4 weeks ago

    changed time estimate to 1d

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 10 4 weeks ago

    changed weight to 10

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 1d 2h 4 weeks ago

    changed time estimate to 1d 2h

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label and automatically removed Status::Scheduling label 4 weeks ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::InProgress scoped label and automatically removed Status::Backlog label 4 weeks ago

    added scoped label and automatically removed label

  • Emiliano Balbuena @edgebal removed Status::InProgress label 4 weeks ago

    removed label

  • Emiliano Balbuena @edgebal added Status::InProgress scoped label 3 weeks ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet removed Status::InProgress label 3 weeks ago

    removed label

  • Brian Hatchet :speech_balloon: @brianhatchet removed 1 deleted label 3 weeks ago

    removed 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label 3 weeks ago

    added 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label 3 weeks ago

    added scoped label

  • Brian Hatchet :speech_balloon: @brianhatchet changed weight to 12 3 weeks ago

    changed weight to 12

  • Brian Hatchet :speech_balloon: @brianhatchet changed time estimate to 1d 4h 3 weeks ago

    changed time estimate to 1d 4h

  • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label and removed 1 deleted label 2 weeks ago

    added 1 deleted label and removed 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet removed 1 deleted label 2 weeks ago

    removed 1 deleted label

  • Brian Hatchet :speech_balloon: @brianhatchet added 1 deleted label 2 weeks ago

    added 1 deleted label

  • Emiliano Balbuena @edgebal added Status::InProgress scoped label and automatically removed Status::Backlog label 1 week ago

    added scoped label and automatically removed label

  • Emiliano Balbuena @edgebal removed 1 deleted label 1 week ago

    removed 1 deleted label

  • Emiliano Balbuena @edgebal added Sprint::12/25 Wan Wren scoped label 1 week ago

    added scoped label

  • Emiliano Balbuena @edgebal changed the description 6 days ago

    changed the description

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 6 days ago
    Developer

    Following up with @brianhatchet's work as a MR (unleash-client-php!2 (merged))

  • Emiliano Balbuena @edgebal added 1d 4h of time spent at 2019-12-27 6 days ago

    added 1d 4h of time spent at 2019-12-27

  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 6 days ago
    Developer

    Missing/Done:

    • Spec tests for entities
    • Spec tests for factories
    • Spec tests for strategy algorithms
    • Spec tests for resolver
    • Spec tests for main class (Unleash)
    • Smoke testing on Minds
    Edited by Emiliano Balbuena 5 days ago
  • Emiliano Balbuena
    Emiliano Balbuena @edgebal · 6 days ago
    Developer

    Task was underestimated. Reasons are:

    • Clean up and code quality tasks required a bigger refactor than estimated
    • Cache was misbehaving as Unleash server response changes when switching environments (Application Name field)
    • GitLab's User IDs Rollout Strategy is bugged and cannot be saved (see image below), that caused delays on implementation for that strategy until I found it's also present as a subset of Percent rollout > Include additional user IDs

    Faulty GitLab strategy:

    image

    Edited by Emiliano Balbuena 6 days ago
  • Emiliano Balbuena @edgebal added 5h of time spent at 2019-12-27 5 days ago

    added 5h of time spent at 2019-12-27

  • Emiliano Balbuena @edgebal added Status::BuddyReview scoped label and automatically removed Status::InProgress label 5 days ago

    added scoped label and automatically removed label

  • Emiliano Balbuena @edgebal assigned to @brianhatchet and @benhayward.ben and unassigned @edgebal 5 days ago

    assigned to @brianhatchet and @benhayward.ben and unassigned @edgebal

  • Emiliano Balbuena @edgebal mentioned in merge request unleash-client-php!1 5 days ago

    mentioned in merge request unleash-client-php!1

  • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::01/01 - Xerothermic Xenarthra scoped label and automatically removed Sprint::12/25 Wan Wren label 21 hours ago

    added scoped label and automatically removed label

  • Brian Hatchet :speech_balloon: @brianhatchet closed 32 minutes ago

    closed

  • Brian Hatchet :speech_balloon: @brianhatchet removed Status::BuddyReview label 32 minutes ago

    removed label

Please register or sign in to reply
2 Assignees
Brian Hatchet's avatar
Ben Hayward's avatar
none
Epic
None
Unleash feature toggles
Milestone
Unleash feature toggles
Time tracking
Spent 2d 1h
Est 1d 4h
None
Due date
None
5
Labels
Priority::2 - Normal Product::Platform Sprint::01/01 - Xerothermic Xenarthra Squad::Yellow Type::Feature
12
Weight
12
Confidentiality
Not confidential
Lock issue
Unlocked
4
4 participants
user avatar
Brian Hatchet
user avatar
Ben Hayward
user avatar
Emiliano Balbuena
user avatar
Mark Harding
Reference: minds/engine#965