Clean up the unleash client and implement the strategies
- unleash-client-php!1: This merge request includes all the work done by @brianhatchet, complete with a psr compliant caching interface.
- unleash-client-php!2 (merged): Clean up and strategies implementation
We want to make it Unleash compliant, but for our purposes we can focus on the gitlab version
https://docs.gitlab.com/ee/user/project/operations/feature_flags.html
Specifically, we need to implement the strategies section
https://docs.gitlab.com/ee/user/project/operations/feature_flags.html#feature-flag-strategies
changed milestone to %Unleash feature toggles
added 1 deleted label
added scoped labels
changed weight to 4
changed the description
unassigned @brianhatchet
removed 1 deleted label
added scoped label and automatically removed label
- Developer
Hijacking this one as the remainder of the work to be done card.
assigned to @edgebal
added scoped label
changed weight to 8
added 1 deleted label
changed title from C to C
changed the description
changed time estimate to 1d
changed weight to 10
changed time estimate to 1d 2h
added scoped label and automatically removed label
added scoped label and automatically removed label
removed label
added scoped label
removed label
removed 1 deleted label
added 1 deleted label
added scoped label
changed weight to 12
changed time estimate to 1d 4h
added 1 deleted label and removed 1 deleted label
removed 1 deleted label
added 1 deleted label
added scoped label and automatically removed label
removed 1 deleted label
added scoped label
changed the description
- Developer
Following up with @brianhatchet's work as a MR (unleash-client-php!2 (merged))
added 1d 4h of time spent at 2019-12-27
- Developer
Missing/Done:
- Spec tests for entities
- Spec tests for factories
- Spec tests for strategy algorithms
- Spec tests for resolver
- Spec tests for main class (Unleash)
- Smoke testing on Minds
Edited by Emiliano Balbuena - Developer
Task was underestimated. Reasons are:
- Clean up and code quality tasks required a bigger refactor than estimated
- Cache was misbehaving as Unleash server response changes when switching environments (
Application Name
field) - GitLab's
User IDs
Rollout Strategy is bugged and cannot be saved (see image below), that caused delays on implementation for that strategy until I found it's also present as a subset ofPercent rollout > Include additional user IDs
Faulty GitLab strategy:
Edited by Emiliano Balbuena added 5h of time spent at 2019-12-27
added scoped label and automatically removed label
assigned to @brianhatchet and @benhayward.ben and unassigned @edgebal
mentioned in merge request unleash-client-php!1
added scoped label and automatically removed label
closed
removed label