Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 384
  • Merge Requests 55
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !706

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/VacantViper](hotfix/staging): Quick fix to switch mature flag check to is_mature.

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

Summary

Closes #2390 (closed)

Recent overlay change !697 (diffs) Is checking for the mature flag, not the is_mature flag. mature flag is set by the "see mature content" checkbox in settings.

Steps to test

  1. In one browser log into the admin account.
  2. In another browser create a new account or use an existing one with no NSFW or mature flags set. (a2)
  3. In the channel dropdown of that user make a users channel nsfw for Pornography.
  4. Reload profile in a window of a seperate browser.
  5. You should see the overlay, refresh and check it has stuck properly.
  6. Unset NSFW, then click set as explicit (this sets is_mature)
  7. Refresh the channel.
  8. Mature content overlay should show.
  • Not NSFW https://fix-explicit-overlay-channel-1130.minds.io/nemofin/
  • Not NSFW https://fix-explicit-overlay-channel-1130.minds.io/minds/
  • NSFW https://fix-explicit-overlay-channel-1130.minds.io/testacc2/

Estimated Regression Scope

Same as the previous card, an issue would likely manifest wherein the overlay is shown at inappropriate times. Very unlikely; the channel could break altogether if an error is thrown inside of the overlay.

Edited 1 week ago by Ben Hayward
Request to merge hotfix/mature-channel-overlay into master
Pipeline #104741590 failed for 096d0ac5 on hotfix/mature-channel-overlay
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Guy Thouret
              Guy Thouret
              Martin Santangelo
              Martin Santangelo
              Juan Manuel Solaro
              Juan Manuel Solaro
              Rami Albatal
              Rami Albatal

              Merged by Mark Harding 11 minutes ago

              The changes were merged into master with c8de38d6

              The source branch has been deleted

              Closed #2390 (closed)

              Pipeline #106575387 running for c8de38d6 on master
                            • Ben Hayward @benhayward.ben added Squad::Yellow Status::BuddyReview scoped labels 1 week ago

                              added scoped labels

                            • Ben Hayward @benhayward.ben changed the description 1 week ago

                              changed the description

                            • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::BuddyReview label 1 week ago

                              added scoped label and automatically removed label

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                              approved this merge request

                            • Emiliano Balbuena @edgebal approved this merge request 1 week ago

                              approved this merge request

                            • Emiliano Balbuena
                              Emiliano Balbuena @edgebal · 1 week ago
                              Developer

                              Code looks OK, but sandbox is down and Xander won't be able to test. I'm restarting it, but not sure if there's some special --set flag to use.

                              cc/ @benhayward.ben @brianhatchet

                            • Emiliano Balbuena @edgebal assigned to @benhayward.ben 1 week ago

                              assigned to @benhayward.ben

                            • Mark Harding @markeharding approved this merge request 11 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 11 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit c8de38d6 11 minutes ago

                              mentioned in commit c8de38d6

                            Please register or sign in to reply
                            Assignee
                            Ben Hayward's avatar
                            Ben Hayward @benhayward.ben
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            Squad::Yellow Status::Awaiting Review
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Olivia Madrid
                            user avatar
                            Guy Thouret
                            user avatar
                            Martin Santangelo
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Rami Albatal
                            user avatar
                            Xander Miller
                            user avatar
                            Marcelo Rivera
                            Reference: minds/front!706

                            Now you can access the merge request navigation tabs at the top, where they’re easier to find.

                            More information and share feedback