Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 383
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !708

Merged
Opened 6 days ago by Emiliano Balbuena@edgebal
Report abuse

Pro video thumbnail container to use full height

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Summary

Fix Pro video thumbnails when they're not set to 16:9

Closes #2250 (closed)

Steps to test

  • Ensure your channel is Pro
  • Upload at least 1 video, if you haven't
  • Go to your channel > Pro > Settings > Theme
  • Tiles Aspect Ratio > Select 1:1
  • Click Save
  • Preview your channel. There should be no transparent space between the video area and the its title box.

Note: Video thumbnails are not working on sandboxes, so I was only able to test with the black default background for these images.

Old behavior: image

Fixed: image

Estimated Regression Scope

Regressions will most likely just affect how video thumbnails look on Pro page tile lists, and any other page which use the same component/class

Edited 6 days ago by Emiliano Balbuena
Request to merge fix/pro-video-thumbnail into master
Pipeline #105184218 passed with warnings for de71b055 on fix/pro-video-thumbnail
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Martin Santangelo
              Martin Santangelo
              Guy Thouret
              Guy Thouret
              Marcelo Rivera
              Marcelo Rivera
              Juan Manuel Solaro
              Juan Manuel Solaro
              Olivia Madrid
              Olivia Madrid

              Merged by Mark Harding 1 hour ago

              The changes were merged into master with a421ed22

              The source branch has been deleted

              Closed #2250 (closed)

              Pipeline #106194285 waiting for manual action for a421ed22 on master
                            • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 6 days ago

                              added scoped label

                            • Emiliano Balbuena @edgebal changed the description 6 days ago

                              changed the description

                            • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label 6 days ago

                              added scoped label

                            • Emiliano Balbuena @edgebal assigned to @benhayward.ben and unassigned @edgebal 6 days ago

                              assigned to @benhayward.ben and unassigned @edgebal

                            • Emiliano Balbuena @edgebal changed milestone to %Misc. Q4 2019 6 days ago

                              changed milestone to %Misc. Q4 2019

                            • Mark Harding @markeharding approved this merge request 1 hour ago

                              approved this merge request

                            • Mark Harding @markeharding merged 1 hour ago

                              merged

                            • Mark Harding @markeharding mentioned in commit a421ed22 1 hour ago

                              mentioned in commit a421ed22

                            Please register or sign in to reply
                            Assignee
                            Ben Hayward's avatar
                            Ben Hayward @benhayward.ben
                            Misc. Q4 2019
                            Milestone
                            Misc. Q4 2019
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            Squad::Yellow Status::Awaiting Review
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Martin Santangelo
                            user avatar
                            Guy Thouret
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Rami Albatal
                            user avatar
                            Xander Miller
                            Reference: minds/front!708

                            Now you can access the merge request navigation tabs at the top, where they’re easier to find.

                            More information and share feedback