Closes #2289

Summary:

This change behaves differently if you are on a subdomain.

https://subverse.net, vs https://www.minds.com/pro/subverse

Currently on production, on a subdomain, the logo of the pro user is supposed to show, but it does not. On a non sub-domain, the Minds logo is supposed to show up.

Issue's I'm aware of

There's two modals loading on non-subdomains. This looks a bit like a huge shadow. This is to be dealt with in another card here: minds#981

Steps to reproduce

1. First log out!
2. Make a new account
3. Log into admin and give the new account pro.

a) go to channel of the user you want to grant it to. b) hit the briefcase icon on the profile sidebar.

Standard Minds domain

1. Log out again.
2. Visit your new pro channel
3. Verify your avatar is shown on the users pro profile
4. Scrolling down it not logged in, should show the minds logo.
5. Set a logo.
6. Logo should show on page instead of avatar.
7. Scroll down, modal should trigger and the Minds logo should still be shown.

On a subdomain

1. Visit https://pro-domain--fix-pro-logo-modal-2289.minds.io/
2. Click a new tab
3. Scroll down
4. In popup modal you should see your chosen logo.

Optionally, to make your own subdomain:

1. Message me to vacate the above URL.
2. go to fix-pro-logo-modal-2289.minds.io
3. enable Pro on the channel you need
4. go to Pro Settings > Domain > Enter pro-domain--fix-pro-logo-modal-2289.minds.io
5. Click save
6. Check that you have a pro logo set, if you don't, add one.
7. On another tab, go to pro-domain--fix-pro-logo-modal-2289.minds.io
8. You should see the Pro for the channel you set up
9. Log out

No pro user set, avatar still shown

On a subdomain

minds.com/pro/

added scoped label

added 1 commit

• 8b6d2845 - Tidying

Compare with previous version

Well, for starters, I am unable to give myself a pro account on this review site. The current /pro page is broken and the console throws

TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null"

errors until it crashes

Also, passing off issues onto the tests with a note to "figure it out" is unacceptable. If there's issues with the review sites that prevent testing, we need to get them sorted out and probably promote this to a Beatle's server in the mean time. But, it's your responsibility to get the resources ironed out so we can this properly.

On a subdomain

1. /etc/hosts edit may need to be made on the sandbox, alternatively, speak with @edgebal, he may know a way to simulate it.

Intended as less of a figure it out for yourself and more of a warning that it was considerable effort to do, and local testing would be preferred - that said if you want to go down that road we need:

a) A fresh domain and Minds hosted on an EC2 or write access to K8s pods.

b) A fresh domain and a helm mapping spawning 2 Traefik frontends.

Spoke with Emi, he is going to prepare the helm charts so that this can be tested on the sandboxes; may still need access to DNS.

changed the description

added scoped label

changed the description

assigned to @benhayward.ben and @edgebal

added scoped label

added scoped label and automatically removed label

Moving this to Requires Changes until we can get these review sites ironed out

added 1 commit

• e89dee8c - Removed unneccesary conditional

Compare with previous version

unassigned @edgebal

As a heads up, I've uploaded a Helm Chart change that adds extra domain we can use for E2E spec testing (minds/helm-charts#master), however, the ideal solution would be to implement wildcard SSL-enabled domains for all sandboxes.

Tracking issue: #2316

Can we change label back to Status::Awaiting Review @benhayward.ben ?