Summary

Videos on Pro are not properly cropped or centered when aspect ratio is changed

Steps to reproduce

1. /pro/{user}/settings/assets
2. change aspect ratio to 1:1
3. view pro channel video posts will be badly cropped or centered

Platform information

browser

What is the current bug behavior?

video posts break 1:1 aspect ratio grid

What is the expected correct behavior?

video posts should be cropped or vertically center for 1:1 grid

Relevant logs and/or screenshots

grid

changed milestone to %Pro Beta #release

added scoped label

added scoped labels and automatically removed label

unassigned @edgebal

I'm not sure what we want to do here, as videos will mostly be 16:9. Why are we allowing tile ratio anyway?

/cc @edgebal @ottman

I would leave that up to you all, but based on your comment about bitrate I just want to be sure that we are actually getting the benefits of sharper videos with 1080

assigned to @edgebal

Probably we should make the video thumbnail to cover the whole container.

added scoped label

added scoped label

changed time estimate to 4h

changed weight to 4

added scoped label

added scoped label and automatically removed label

removed label

added scoped label

assigned to @markeharding

Might be fixed by @markeharding's revamp to video component.

added scoped label and automatically removed label

unassigned @markeharding

added scoped label and automatically removed label

Now that @markeharding's video component has been released, can you reverify if this has been fixed @edgebal

added scoped label and automatically removed label

changed weight to 2

changed time estimate to 2h

Issue is still present. https://www.minds.com/pro/xander/videos

added scoped label and automatically removed label

mentioned in merge request !708 (merged)

added 1h of time spent at 2019-12-24

Had some issues booting up the sandbox site and figuring out why the thumbnails were not working.

added scoped label and automatically removed label

assigned to @benhayward.ben and unassigned @edgebal

closed via merge request !708 (merged)

mentioned in commit a421ed22