Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 428
  • Merge Requests 57
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !708

Open
Opened 9 hours ago by Emiliano Balbuena@edgebal
Report abuse

Pro video thumbnail container to use full height

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Summary

Fix Pro video thumbnails when they're not set to 16:9

Closes #2250

Steps to test

  • Ensure your channel is Pro
  • Upload at least 1 video, if you haven't
  • Go to your channel > Pro > Settings > Theme
  • Tiles Aspect Ratio > Select 1:1
  • Click Save
  • Preview your channel. There should be no transparent space between the video area and the its title box.

Note: Video thumbnails are not working on sandboxes, so I was only able to test with the black default background for these images.

Old behavior: image

Fixed: image

Estimated Regression Scope

Regressions will most likely just affect how video thumbnails look on Pro page tile lists, and any other page which use the same component/class

Edited 4 hours ago by Emiliano Balbuena
Request to merge fix/pro-video-thumbnail into master
Open in Web IDE
Pipeline #105184218 passed with warnings for de71b055 on fix/pro-video-thumbnail
              Requires 3 more approvals from Devs, Deployers, and QA.
              Martin Santangelo
              Martin Santangelo
              Marcelo Rivera
              Marcelo Rivera
              Guy Thouret
              Guy Thouret
              Ben Hayward
              Ben Hayward
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2250

              Deletes source branch

              • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 9 hours ago

                added scoped label

              • Emiliano Balbuena @edgebal changed the description 4 hours ago

                changed the description

              • Emiliano Balbuena @edgebal added Status::Awaiting Review scoped label 4 hours ago

                added scoped label

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben and unassigned @edgebal 4 hours ago

                assigned to @benhayward.ben and unassigned @edgebal

              • Emiliano Balbuena @edgebal changed milestone to %Misc. Q4 2019 4 hours ago

                changed milestone to %Misc. Q4 2019

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              Misc. Q4 2019
              Milestone
              Misc. Q4 2019
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Martin Santangelo
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              user avatar
              Rami Albatal
              Reference: minds/front!708

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback