Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 426
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !706

Open
Opened 2 days ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/VacantViper](hotfix/staging): Quick fix to switch mature flag check to is_mature.

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

Summary

Closes #2390

Recent overlay change !697 (diffs) Is checking for the mature flag, not the is_mature flag. mature flag is set by the "see mature content" checkbox in settings.

Steps to test

  1. In one browser log into the admin account.
  2. In another browser create a new account or use an existing one with no NSFW or mature flags set. (a2)
  3. In the channel dropdown of that user make a users channel nsfw for Pornography.
  4. Reload profile in a window of a seperate browser.
  5. You should see the overlay, refresh and check it has stuck properly.
  6. Unset NSFW, then click set as explicit (this sets is_mature)
  7. Refresh the channel.
  8. Mature content overlay should show.
  • Not NSFW https://fix-explicit-overlay-channel-1130.minds.io/nemofin/
  • Not NSFW https://fix-explicit-overlay-channel-1130.minds.io/minds/
  • NSFW https://fix-explicit-overlay-channel-1130.minds.io/testacc2/

Estimated Regression Scope

Same as the previous card, an issue would likely manifest wherein the overlay is shown at inappropriate times. Very unlikely; the channel could break altogether if an error is thrown inside of the overlay.

Edited 2 days ago by Ben Hayward
Request to merge hotfix/mature-channel-overlay into master
Open in Web IDE
Pipeline #104741590 failed for 096d0ac5 on hotfix/mature-channel-overlay
              Requires approval from QA. Approved by
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding
              Marcelo Rivera
              Marcelo Rivera
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Rami Albatal
              Rami Albatal
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2390

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow Status::BuddyReview scoped labels 2 days ago

                added scoped labels

              • Ben Hayward @benhayward.ben changed the description 2 days ago

                changed the description

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::BuddyReview label 2 days ago

                added scoped label and automatically removed label

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

                approved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 2 days ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 27 minutes ago
                Developer

                Code looks OK, but sandbox is down and Xander won't be able to test. I'm restarting it, but not sure if there's some special --set flag to use.

                cc/ @benhayward.ben @brianhatchet

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 13 minutes ago

                assigned to @benhayward.ben

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Mark Harding
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Rami Albatal
              user avatar
              Xander Miller
              user avatar
              Martin Santangelo
              Reference: minds/front!706

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback