Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 426
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !703

Open
Opened 4 days ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/VacantViper](fix) Live refresh of comments thread on entity change. #1658

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1
0/1 thread resolved

Summary

Closes #1658

Comment threads currently do not live refresh, so if the original input entity changes, the thread does not update. This is not problematic for most usecases as the entity is usually fixed, but in situations like the firehose, it changes on approval / rejection.

This meant that when approving and rejecting, the old comments stayed in place on the wrong entity.

Steps to test

  1. Log in as admin
  2. Make 5x posts with the content: adult 1, adult 2, adult 3, adult 4, adult 5
  3. Comment on each of these posts (maybe multiple times but not essential) comment 1, comment 2 etc
  4. In admin panel, go to firehose
  5. First entry should be your new post (adult is a keyword watched by the firehose)
  6. Open the comments - be sure the comment is there.
  7. Click approve, it should load the next post's comments automatically.
  8. Try reject, it should do the same.

Estimated Regression Scope

This affects all comment threads on the side, though only in the way of their change detection. Regressions relating to the updating of threads are possible There was an issue I had during development where it was triggering on the initial input, rather than changes, thus duplicating comments and XHR requests.

Request to merge fix/admin-firehose-1658 into master
The source branch is 3 commits behind the target branch
Open in Web IDE
Pipeline #104204287 passed with warnings for d185b744 on fix/admin-firehose-1658
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Marcelo Rivera
              Marcelo Rivera
              Guy Thouret
              Guy Thouret
              Emiliano Balbuena
              Emiliano Balbuena
              Olivia Madrid
              Olivia Madrid
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1658

              Deletes source branch

              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 4 days ago

                added scoped label

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label 4 days ago

                added scoped label

              • Ben Hayward @benhayward.ben added Status::BuddyReview scoped label and automatically removed Status::Awaiting Review label 4 days ago

                added scoped label and automatically removed label

              • Xander Miller
                Xander Miller @xander-miller · 3 days ago
                Developer

                seen at buddy review

              • Ben Hayward @benhayward.ben assigned to @benhayward.ben 3 days ago

                assigned to @benhayward.ben

              • Ben Hayward @benhayward.ben assigned to @edgebal 3 days ago

                assigned to @edgebal

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 3 days ago
                Developer

                Seems like the indexing runner is not working correctly on the sandbox.

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 49 minutes ago
                Developer

                Looks like this sandbox's indexer is still having issues

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on the diff 47 minutes ago
                src/app/modules/comments/thread/thread.component.ts
                320 320 }
                321 321
                322 322 ngOnChanges(changes) {
                323 // console.log('[comment:list]: on changes', changes);
                323 // console.log('[comment:thread]: on changes', changes);
                324
                325 // reload on entity change.
                326 if (changes.entity && changes.entity.previousValue) {
                • Emiliano Balbuena
                  Emiliano Balbuena @edgebal · 47 minutes ago
                  Developer

                  In order to avoid unnecessary reloads, can we also check the entity's GUID against the previous value?

                • Please register or sign in to reply
              • Emiliano Balbuena @edgebal added Status::Requires Changes scoped label and automatically removed Status::BuddyReview label 46 minutes ago

                added scoped label and automatically removed label

              • Emiliano Balbuena @edgebal unassigned @edgebal 46 minutes ago

                unassigned @edgebal

              Please register or sign in to reply
              Assignee
              Ben Hayward's avatar
              Ben Hayward @benhayward.ben
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Mark Harding
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Olivia Madrid
              user avatar
              Rami Albatal
              user avatar
              Xander Miller
              Reference: minds/front!703

              Now you can access the merge request navigation tabs at the top, where they’re easier to find.

              More information and share feedback