Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 288
  • Merge Requests 31
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !431

Merged
Opened 2 days ago by Guy Thouret@gthouret
Report abuse

WIP: Fix Campaigns get marked as complete on first view

  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 4

Fixes #1252

Request to merge fix-campaign-complete-1252 into epic/boost-campaign
Pipeline #104728592 passed for c9b4b04f on fix-campaign-complete-1252
          Requires 3 more approvals from Devs, Deployers, and QA.
          Brian Hatchet
          Brian Hatchet
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Ben Hayward
          Ben Hayward
          Emiliano Balbuena
          Emiliano Balbuena

          Merged by Guy Thouret 15 hours ago

          The changes were merged into epic/boost-campaign with c9b4b04f

          • Guy Thouret @gthouret added Sprint::12/18 Vacant Viper Squad::Blue Status::Awaiting Review Type::Bug scoped labels 2 days ago

            added scoped labels

          • Guy Thouret
            Guy Thouret @gthouret · 2 days ago
            Developer

            Currently throwing a 500 for:

            2019/12/20 16:57:04 [error] 8#8: *1372 FastCGI sent in stderr: "PHP message: Exception #1576861024: Exception: Expected a numeric value in /var/www/Minds/engine/Core/Util/BigNumber.php:385
            Stack trace:
            #0 /var/www/Minds/engine/Core/Util/BigNumber.php(30): Minds\Core\Util\BigNumber->normalize('')
            #1 /var/www/Minds/engine/Core/Util/BigNumber.php(331): Minds\Core\Util\BigNumber->__construct(NULL, 18)
            #2 /var/www/Minds/engine/Core/Boost/Network/ElasticRepository.php(280): Minds\Core\Util\BigNumber::fromPlain(NULL, 18)
            #3 /var/www/Minds/engine/Core/Boost/Network/ElasticRepository.php(344): Minds\Core\Boost\Network\ElasticRepository->add(Object(Minds\Core\Boost\Network\Boost))
            #4 /var/www/Minds/engine/Core/Boost/Network/Manager.php(171): Minds\Core\Boost\Network\ElasticRepository->update(Object(Minds\Core\Boost\Network\Boost), Array)
            #5 /var/www/Minds/engine/Core/Boost/Network/Manager.php(166): Minds\Core\Boost\Network\Manager->resync(Object(Minds\Core\Boost\Network\Boost), Array)
            #6 /var/www/Minds/engine/Core/Boost/Network/Manager.php(210): Minds\Core\Boost\Network\Manager" while reading response header from upstream, client: 172.18.0.1, server: _, request: "POST /api/v2/analytics/views/boost/1054801464335011857 HTTP/1.1", upstream: "fastcgi://172.18.0.6:9000", host: "localhost:8080", referrer: "http://localhost:8080/newsfeed/subscriptions"
          • Guy Thouret
            Guy Thouret @gthouret · 2 days ago
            Developer

            To make a campaign compatible with legacy code during deployment we should just set the unused 'impressions' field to a really large integer or this 'bug' will be triggered if a campaign post is picked up before the new code has fully rolled out. Perhaps by setting a default in the campaign model that we never override when constructing a new model from repository.

          • Guy Thouret @gthouret added 5 commits 2 days ago

            added 5 commits

            • 77fa1e27 - (fix) Add guid query to Boost ElasticRepository - Fixes #1249
            • 4f8b37e4 - (feat) Admins can approve posts in a Boost Campaign - #1170 (closed)
            • c9d6b183 - Merge branch 'fix-campaign-view-1249' into 'epic/boost-campaign'
            • d55c3324 - Merge branch 'feat/1170-admin-approve-campaign' into 'epic/boost-campaign'
            • c9b4b04f - (fix) Correct handling of Boost campaign views and expiry - #1252

            Compare with previous version

            Toggle commit list
          • Guy Thouret @gthouret changed target branch from master to epic/boost-campaign 2 days ago

            changed target branch from master to epic/boost-campaign

          • Guy Thouret
            Guy Thouret @gthouret · 2 days ago
            Developer

            Mr was targeting the wrong branch

          • Guy Thouret @gthouret merged 15 hours ago

            merged

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          4
          Labels
          Sprint::12/18 Vacant Viper Squad::Blue Status::Awaiting Review Type::Bug
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Brian Hatchet
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          user avatar
          Emiliano Balbuena
          user avatar
          Olivia Madrid
          user avatar
          Rami Albatal
          Reference: minds/engine!431

          Now you can access the merge request navigation tabs at the top, where they’re easier to find.

          More information and share feedback