(cache)[Sprint/VacantViper](hotfix/staging): Quick fix to switch mature flag check to is_mature. (!706) · Merge Requests · Minds / Minds Frontend

[Sprint/VacantViper](hotfix/staging): Quick fix to switch mature flag check to is_mature.

Summary

Recent overlay change !697 (diffs) Is checking for the mature flag, not the is_mature flag. mature flag is set by the "see mature content" checkbox in settings.

Steps to test

In one browser log into the admin account.
In another browser create a new account or use an existing one with no NSFW or mature flags set. (a2)
In the channel dropdown of that user make a users channel nsfw for Pornography.
Reload profile in a window of a seperate browser.
You should see the overlay, refresh and check it has stuck properly.
Unset NSFW, then click set as explicit (this sets is_mature)
Refresh the channel.
Mature content overlay should show.

Estimated Regression Scope

Same as the previous card, an issue would likely manifest wherein the overlay is shown at inappropriate times. Very unlikely; the channel could break altogether if an error is thrown inside of the overlay.

### Summary

Closes https://gitlab.com/minds/front/issues/2390

Recent overlay change https://gitlab.com/minds/front/merge_requests/697/diffs
Is checking for the mature flag, not the is_mature flag. mature flag is set by the "see mature content" checkbox in settings.

### Steps to test

1. In one browser log into the admin account.
2. In another browser create a new account or use an existing one with no NSFW or mature flags set. (a2)
3. In the channel dropdown of that user make a users channel nsfw for Pornography.
4. Reload profile in a window of a seperate browser.
5. You should see the overlay, refresh and check it has stuck properly.
6. Unset NSFW, then click `set as explicit` (this sets is_mature)
7. Refresh the channel.
8. Mature content overlay should show.

* Not NSFW https://fix-explicit-overlay-channel-1130.minds.io/nemofin/
* Not NSFW https://fix-explicit-overlay-channel-1130.minds.io/minds/
* NSFW https://fix-explicit-overlay-channel-1130.minds.io/testacc2/

### Estimated Regression Scope

Same as the previous card, an issue would likely manifest wherein the overlay is shown at inappropriate times. 
Very unlikely; the channel could break altogether if an error is thrown inside of the overlay.

Edited 1 day ago by Ben Hayward

Request to merge hotfix/mature-channel-overlay into master

Open in Web IDE

Ben Hayward @benhayward.ben added Squad::Yellow Status::BuddyReview scoped labels 1 day ago

added scoped labels
Ben Hayward @benhayward.ben changed the description 1 day ago

changed the description
Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::BuddyReview label 1 day ago

added scoped label and automatically removed label
Brian Hatchet @brianhatchet approved this merge request 1 day ago

approved this merge request
Emiliano Balbuena @edgebal approved this merge request 1 day ago

approved this merge request

Please register or sign in to reply