CR Product Pages
See below a list of items relating to the Product Pages Creative Review.
General Product Pages
- Navigation. Remove bottom border under main navigation. Subtle change, but it will allow the existing navigation to better fit in with the new design.
- Increase the padding under the main navigation, so the spacing matches the designs a little better.
-
Set a
min-width
on page containers of320px
. - Reduce spacing below the footer so it better matches the designs. Currently there is too much vertical white space below the footer.
-
Please change the border style in the footer so it better matches the original designs.
dashed
border can be styled using--dash-size
and--gap-size
in order to get a better match. - These pages could benefit from a better responsive implementation.
- Optimised across small, medium and large screens. Currently just small and large are accounted for. Please see updated designs accounting for the medium layout.
- Medium/tablet view can be found here -> Loading Share Experience
- The page margin for large (as shown in design) should be present throughout.
Pro Page
-
The Pro Page layout shouldn’t contain the red
Cancel Pro
button, if a user is already a Pro user. It would be better if the page simply contained a ‘disabled’ signup form, with a discrete prompt to manage / chancel subscription. Please find attached designs. -> Loading Share Experience - something likeManage Subscription
would be a more better CTA. Functionally it would be a bit pecicular if the user was able to cancel their subscription directly from an outward facing page.
changed milestone to %Pro Beta #release
added scoped label
added scoped label
added scoped label
added scoped label
added scoped label
added scoped label and automatically removed label
marked the task Set a on page containers of . as completed
marked the task Reduce spacing below the footer so it better matches the designs. Currently there is too much vertical white space below the footer. as completed
changed time estimate to 4h
added 2h of time spent at 2019-11-18
added scoped label and automatically removed label
added scoped label
changed due date to December 04, 2019
changed due date to November 27, 2019
marked the task The Pro Page layout shouldn’t contain the red button, if a user is already a Pro user. It would be better if the page simply contained a ‘disabled’ signup form, with a discrete prompt to manage / chancel subscription. Please find attached designs. -> - something like would be a more better CTA. Functionally it would be a bit pecicular if the user was able to cancel their subscription directly from an outward facing page. as completed
added scoped label and automatically removed label
marked the task Please change the border style in the footer so it better matches the original designs. border can be styled using and in order to get a better match. as completed
marked the task Increase the padding under the main navigation, so the spacing matches the designs a little better. as completed
marked the task Navigation. Remove bottom border under main navigation. Subtle change, but it will allow the existing navigation to better fit in with the new design. as completed
added scoped labels and automatically removed labels
- Developer
@eiennohi Since this is going directly to master without a feature flag, please address @michaelfbradley 's changes and we'll review it again