Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 286
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !421

Open
Opened 2 hours ago by Emiliano Balbuena@edgebal
Report abuse

(fix): Pro channel group listing

Testing

URL: https://fix-pro-user-groups.minds.io

  • Sign up with a new channel (or use a existing Pro one)
  • Create several groups, some open, some closed. Ensure they have an avatar and/or a banner
  • Sign up/log in with other channels and join the main channel groups. Create groups with these users as well.
  • Log back in onto the main channel and join the other channels' groups.
  • Use an administrator channel to enable Pro for the new channel (if new). Set up accordingly.
  • Go to main channel's Pro profile (i.e. https://fix-pro-user-groups.minds.io/pro/0xemi)
  • Click Groups
  • You should see the groups that are public and owned by the main channel sorted by member count

Issues

  • Closes front#2306
Edited 53 minutes ago by Emiliano Balbuena
Request to merge fix/pro-user-groups into master
Open in Web IDE
Pipeline #102417813 passed for 526c7bb8 on fix/pro-user-groups
          Requires 3 more approvals from Devs, Deployers, and QA.
          Brian Hatchet
          Brian Hatchet
          Mark Harding
          Mark Harding
          Guy Thouret
          Guy Thouret
          Olivia Madrid
          Olivia Madrid
          Ben Hayward
          Ben Hayward
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes front#2306

          Deletes source branch

          • Discussion 2
          • Commits 2
          • Pipelines 2
          • Changes 6
          0/1 thread resolved
          • Emiliano Balbuena @edgebal added Squad::Yellow Status::Awaiting Review scoped labels 2 hours ago

            added scoped labels

          • Emiliano Balbuena @edgebal added 3 commits 2 hours ago

            added 3 commits

            • d8e66db2...46ac41b1 - 2 commits from branch master
            • 526c7bb8 - Merge remote-tracking branch 'origin/master' into fix/pro-user-groups

            Compare with previous version

          • Emiliano Balbuena @edgebal changed the description 53 minutes ago

            changed the description

          • Ben Hayward
            Ben Hayward @benhayward.ben started a thread on the diff 17 minutes ago
            Core/Groups/Ownership.php
            71 $guids = array_slice($guids, $offset, $limit ?: null);
            72
            73 if (!$guids) {
            74 return new Response();
            75 }
            76
            77 $user = new User();
            78 $user->guid = $this->userGuid;
            79
            80 $response = (new Response(
            81 $this->entitiesBuilder->get(['guids' => $guids])
            82 ))->filter(function ($group) use ($user) {
            83 /** @var Group $group */
            84 return $group && $group->isPublic() && $group->isOwner($user);
            85 })->sort(function ($a, $b) {
            86 /** @var Group $a */
            • Ben Hayward
              Ben Hayward @benhayward.ben · 17 minutes ago
              Developer

              Intentional?

            • Please register or sign in to reply
          • Ben Hayward
            Ben Hayward @benhayward.ben · 8 minutes ago
            Developer

            image

            Is this an unrelated bug? (the banner images)

          Please register or sign in to reply
          Assignee
          Emiliano Balbuena's avatar
          Emiliano Balbuena @edgebal
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          Squad::Yellow Status::Awaiting Review
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Brian Hatchet
          user avatar
          Mark Harding
          user avatar
          Guy Thouret
          user avatar
          Olivia Madrid
          user avatar
          Ben Hayward
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          Reference: minds/engine!421