Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 413
  • Merge Requests 57
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !693

Open
Opened 8 hours ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/UnderstoodUnicorn](fix): Fixed inability to cancel uploaded image. #2334

Summary

Closes #2334

This merge request addresses an issue on production right now where cancelling an image upload causes everything to break.

Steps to test

  1. Fully upload an image
  2. Cancel it
  3. It should cancel
  4. Upload a new image

Repeat but stop the image mid upload.

All should work fine.

Estimated Regression Scope

This change should affect media uploads across the site. Comments, feeds etc. There is an issue where-in you can get the poster to show no attachment after hitting upload - this occurs when it is waiting for the previous XHR to resolve.

Issues handled in another MR

In group chats, when you cancel, an outline window appears #2349

Edited 4 hours ago by Ben Hayward
Request to merge fix/attachment-poster-2334 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
Pipeline #102334811 passed with warnings for 6d26c549 on fix/attachment-poster-2334
              Requires approval from QA. Approved by
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena
              Xander Miller
              Xander Miller
              Mark Harding
              Mark Harding
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2334

              Mentions #2349

              Deletes source branch

              • Discussion 2
              • Commits 2
              • Pipelines 2
              • Changes 1
              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 8 hours ago

                added scoped label

              • Ben Hayward @benhayward.ben changed the description 4 hours ago

                changed the description

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label 4 hours ago

                added scoped label

              • Emiliano Balbuena @edgebal approved this merge request 44 minutes ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 44 minutes ago
                Developer

                Code looks good. Works OK.

              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 44 minutes ago

                assigned to @benhayward.ben

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 25 minutes ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @xander-miller 25 minutes ago

                assigned to @xander-miller

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 25 minutes ago
                Developer

                @xander-miller ready for your review

              Please register or sign in to reply
              2 Assignees
              Xander Miller's avatar
              Ben Hayward's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Xander Miller
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Rami Albatal
              user avatar
              Martin Santangelo
              Reference: minds/front!693