Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 413
  • Merge Requests 57
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !683

Open
Opened 5 days ago by Marcelo Rivera@eiennohi
Report abuse

Use media modal in channel media feeds

closes #2226

Request to merge feat/modal-in-media-feeds-2226 into master
The source branch is 16 commits behind the target branch
Open in Web IDE
Pipeline #101178004 passed with warnings for 317ddbb8 on feat/modal-in-media-feeds-2226
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Emiliano Balbuena
              Emiliano Balbuena
              Rami Albatal
              Rami Albatal
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2226

              Deletes source branch

              • Discussion 3
              • Commits 1
              • Pipelines 1
              • Changes 2
              0/3 threads resolved
              • Marcelo Rivera @eiennohi added MR::Awaiting Review Squad::Yellow scoped labels 5 days ago

                added scoped labels

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                  Developer

                  $CONFIG->max_video_length = 12600; $CONFIG->max_video_file_size = 4294967296; $CONFIG->max_daily_boost_views = 10000;

                  This pod has the default values coming from helm. There's something up with the attachment service. How are you testing these videos on review sites

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 day ago
                src/app/modules/newsfeed/feeds/tiles.component.html
                10 10 [ngClass]="{
                11 11 'm-newsfeed-tiles__Tile--is-mature': attachment.shouldBeBlurred(entity)
                12 12 }"
                13 [routerLink]="['/newsfeed', entity.guid]"
                14 13 >
                15 <img [src]="getThumbnailSrc(entity$ | async)" />
                14 <img
                15 [src]="getThumbnailSrc(entity$ | async)"
                16 (click)="clickedImage(entity, this)"
                • Mark Harding
                  Mark Harding @markeharding · 1 day ago
                  Owner

                  Why is this used?

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 day ago

                added scoped label and automatically removed label

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @eiennohi 1 day ago

                assigned to @eiennohi

              • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::12/11 - Understood Unicorn scoped label 3 minutes ago

                added scoped label

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 minutes ago
                  Developer

                  This works on the review site now, but you still need to address @markeharding 's comment @eiennohi

                • Please register or sign in to reply
              Please register or sign in to reply
              Assignee
              Marcelo Rivera's avatar
              Marcelo Rivera @eiennohi
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              3
              Labels
              Sprint::12/11 - Understood Unicorn Squad::Yellow Status::Requires Changes
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Xander Miller
              user avatar
              Emiliano Balbuena
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              Reference: minds/front!683