Skip to content

Minds Frontend
Minds Frontend
Open
Opened by Ben Hayward@benhayward.ben
Report abuse

[Sprint/UnderstoodUnicorn](fix): Fixed inability to cancel uploaded image. #2334

Summary

Closes #2334

This merge request addresses an issue on production right now where cancelling an image upload causes everything to break.

Steps to test

  1. Fully upload an image
  2. Cancel it
  3. It should cancel
  4. Upload a new image

Repeat but stop the image mid upload.

All should work fine.

Estimated Regression Scope

This change should affect media uploads across the site. Comments, feeds etc. There is an issue where-in you can get the poster to show no attachment after hitting upload - this occurs when it is waiting for the previous XHR to resolve.

Issues handled in another MR

In group chats, when you cancel, an outline window appears #2349

Edited by Ben Hayward
Request to merge fix/attachment-poster-2334 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
Pipeline #102334811 passed with warnings for 6d26c549 on fix/attachment-poster-2334
              Requires approval from QA. Approved by
              Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2334

              Mentions #2349

              Deletes source branch

              Please register or sign in to reply