Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 412
  • Merge Requests 57
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !630

Merged
Opened 1 month ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuial](feat}: Remembering previous state of recurring wire checkbox. #2001

Summary

Closes #2001 (closed)

To test,

Steps to test

  1. Log in
  2. Open up your local storage window

image

  1. Go to /minds, click to open the Wire modal.

  2. Default state should be off.

  3. Check it.

  4. You should see the storage item appear preferred-recurring-wire-state with the value 1.

  5. If you reload the page, and check back, the state should be loaded from the cookie and be on.

  6. Check it off, the local storage item should update to 0.

  7. Refresh, check the modal again, it should be off.

  8. Send a recurring wire, check in settings > subscriptions that it is there and cancel it.

  9. Send a non-recurring wire. Check again but this time make sure it is not there.

Estimated Regression Scope

These changes affect the wire modal, specifically the checkbox - an error in here could cause problems for the whole modal, we should also be checking in your settings > subscriptions that none have been created after trying to send a wire.

Edited 3 hours ago by Ben Hayward
Request to merge feat/store-recurring-checkbox-2001 into master
Pipeline #102383294 passed with warnings for 3afe3c56 on feat/store-recurring-checkbox-2001
              Merge request approved. Approved by
              Xander Miller
              Xander Miller
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Mark Harding
              Mark Harding
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret

              Merged by Xander Miller 17 minutes ago

              The changes were merged into master with 9ba746dd

              The source branch has been deleted

              Closed #2001 (closed)

              Pipeline #102429289 running for 9ba746dd on master
                            • Discussion 5
                            • Commits 2
                            • Pipelines 4
                            • Changes 2
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 month ago

                              added scoped labels

                            • Mark Harding
                              Mark Harding @markeharding · 1 month ago
                              Owner

                              Initial state should still be recurring set to default. This should be inverted.

                              Screenshot_2019-11-05_at_10.09.17

                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 month ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                              added 1 commit

                              • ab24317b - Flipping logic on recurring wire cookie to default to on

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                              added 1 commit

                              • a1540c4a - Updated spec tests

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 month ago

                              added scoped label and automatically removed label

                            • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::12/11 - Understood Unicorn scoped label 5 hours ago

                              added scoped label

                            • Brian Hatchet :speech_balloon: @brianhatchet added Status::Backlog scoped label and automatically removed Status::Awaiting Review label 5 hours ago

                              added scoped label and automatically removed label

                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet · 4 hours ago
                              Developer

                              The initial state should not be set to recurring by default. We need to be clearer on what the "Custom Subscription" rewards do before we can add the "One time" reward

                            • Ben Hayward @benhayward.ben added 105 commits 4 hours ago

                              added 105 commits

                              • a1540c4a...e2bf6f13 - 104 commits from branch master
                              • 3afe3c56 - Merge branch 'master' of gitlab.com:minds/front into feat/store-recurring-checkbox-2001

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet assigned to @benhayward.ben 4 hours ago

                              assigned to @benhayward.ben

                            • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::Backlog label 3 hours ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben changed the description 3 hours ago

                              changed the description

                            • Emiliano Balbuena @edgebal approved this merge request 1 hour ago

                              approved this merge request

                            • Emiliano Balbuena
                              Emiliano Balbuena @edgebal · 1 hour ago
                              Developer

                              Code looks good. Works OK!

                            • Xander Miller
                              Xander Miller @xander-miller · 20 minutes ago
                              Developer

                              e2e Tests are failing. Onboarding spec wasn't failing on a merge request I approved this morning. Updating, pro, plus and newsfeed were as they are now.

                              image

                            • Xander Miller
                              Xander Miller @xander-miller · 17 minutes ago
                              Developer

                              Works for me.

                              image

                            • Xander Miller @xander-miller approved this merge request 17 minutes ago

                              approved this merge request

                            • Xander Miller @xander-miller merged 17 minutes ago

                              merged

                            • Xander Miller @xander-miller mentioned in commit 9ba746dd 17 minutes ago

                              mentioned in commit 9ba746dd

                            Please register or sign in to reply
                            Assignee
                            Ben Hayward's avatar
                            Ben Hayward @benhayward.ben
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            3
                            Labels
                            Sprint::12/11 - Understood Unicorn Squad::Yellow Status::Awaiting Review
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Brian Hatchet
                            user avatar
                            Rami Albatal
                            user avatar
                            Mark Harding
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Guy Thouret
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            Reference: minds/front!630