[Sprint/TrendyTurtle](feat): Added in error message on socket connection breaking. #2115
Summary
Closes #2115 MR to add an error message in to show the user when their connection to live comments has been lost.
Steps to test
This can be tested pretty simply.
- Make a post or go to visit one https://feat-socket-error-comments-2115.minds.io/newsfeed/1049089523444617221
- Keep the page open, drag the tab into its own window so you can watch it whilst you do step 3.
- On the pipeline of this MR. Run the stop job. Do not refresh the page.
- Wait and the disconnect message will show (because the stop job killed the sockets container)
- Don't close the window!
- Start the job again.
- The message should go away when the connection is re-established.
Estimated Regression Scope
The worst-case scenario is are that something could break in sockets or thread comments. E.g. the error showing at inappropriate times if the error is for some reason called more times than necessary on prod, or maybe the load more of the comments thread.
added scoped label
added scoped label
changed the description
added scoped label and automatically removed label
- Developer
Just to highlight, this would not be particularly difficult to implement in other areas of the site.
Please register or sign in to reply