Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 412
  • Merge Requests 58
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !692

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](feat): Added in error message on socket connection breaking. #2115

Summary

Closes #2115 MR to add an error message in to show the user when their connection to live comments has been lost.

Steps to test

This can be tested pretty simply.

  1. Make a post or go to visit one https://feat-socket-error-comments-2115.minds.io/newsfeed/1049089523444617221
  2. Keep the page open, drag the tab into its own window so you can watch it whilst you do step 3.
  3. On the pipeline of this MR. Run the stop job. Do not refresh the page.
  4. Wait and the disconnect message will show (because the stop job killed the sockets container)
  5. Don't close the window!
  6. Start the job again.
  7. The message should go away when the connection is re-established.

image

Estimated Regression Scope

The worst-case scenario is are that something could break in sockets or thread comments. E.g. the error showing at inappropriate times if the error is for some reason called more times than necessary on prod, or maybe the load more of the comments thread.

Edited 3 hours ago by Ben Hayward
Request to merge feat/socket-error-comments-2115 into master
The source branch is 10 commits behind the target branch
Open in Web IDE
Pipeline #102083860 passed with warnings for 41448c5b on feat/socket-error-comments-2115
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Emiliano Balbuena
              Emiliano Balbuena
              Rami Albatal
              Rami Albatal
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2115

              Deletes source branch

              • Discussion 1
              • Commits 3
              • Pipelines 3
              • Changes 5
              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 1 day ago

                added scoped label

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • 5d87644a - Handle errors from CommentsService

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • 41448c5b - Unused imports

                Compare with previous version

              • Ben Hayward @benhayward.ben added Status::Requires Changes scoped label 22 hours ago

                added scoped label

              • Ben Hayward @benhayward.ben changed the description 3 hours ago

                changed the description

              • Ben Hayward @benhayward.ben added Status::Awaiting Review scoped label and automatically removed Status::Requires Changes label 3 hours ago

                added scoped label and automatically removed label

              • Ben Hayward
                Ben Hayward @benhayward.ben · 3 hours ago
                Developer

                Just to highlight, this would not be particularly difficult to implement in other areas of the site.

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              Squad::Yellow Status::Awaiting Review
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Xander Miller
              user avatar
              Emiliano Balbuena
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              Reference: minds/front!692