Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 405
  • Merge Requests 58
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !691

Closed
Opened 1 day ago by Mark Harding@markeharding
Report abuse

New video player

This is a new video player to support the new transcoder

Background is engine!414 (closed)

How to test

  1. Go to the review site (https://epic-transcoder-improvements.minds.io/)
  2. Upload a short video
  3. Wait about 10 mins to transcode
  4. Clicking on play should open the modal

If you run into issues

  • Provide the source file you tried to upload
  • Link to the failed transcode
Edited 43 minutes ago by Mark Harding
Request to merge epic/transcoder-improvements into master
Pipeline #102336069 passed with warnings for 6d2a5fa0 on epic/transcoder-improvements
              Requires approval from Deployers. Approved by
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena
              Ben Hayward
              Ben Hayward
              Rami Albatal
              Rami Albatal
              Juan Manuel Solaro
              Juan Manuel Solaro
              Depends on 1 closed merge request.

              Closed by Mark Harding 5 minutes ago

              The changes were not merged into master

              Deletes source branch

              • Discussion 3
              • Commits 6
              • Pipelines 6
              • Changes 49
              • Mark Harding @markeharding changed milestone to %Transcoder Improvements 1 day ago

                changed milestone to %Transcoder Improvements

              • Mark Harding @markeharding added Priority::1 - High Product::Media Squad::Blue Type::Refactor scoped labels 1 day ago

                added scoped labels

              • Mark Harding @markeharding added 1 commit 1 day ago

                added 1 commit

                • b66e6392 - (fix): some minor fixes

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 1 day ago

                added 1 commit

                • 651d2529 - (chore): background gradient for transcode notices

                Compare with previous version

              • Mark Harding @markeharding mentioned in merge request !684 (closed) 1 day ago

                mentioned in merge request !684 (closed)

              • Mark Harding @markeharding added 1 commit 1 day ago

                added 1 commit

                • 2047c615 - (fix): improved linear gradient for transcoder status

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet mentioned in issue #2074 (closed) 23 hours ago

                mentioned in issue #2074 (closed)

              • Mark Harding @markeharding added 1 commit 2 hours ago

                added 1 commit

                • e9c085da - (fix): full screen mode not firing with plyr

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 1 hour ago

                added 1 commit

                • 6d2a5fa0 - (chore): remove text about notification for now

                Compare with previous version

              • Mark Harding @markeharding unmarked as a Work In Progress 55 minutes ago

                unmarked as a Work In Progress

              • Mark Harding @markeharding changed title from WIP: new video player to New video player 55 minutes ago

                changed title from ew video player to ew video player

              • Mark Harding @markeharding changed the description 43 minutes ago

                changed the description

              • Xander Miller
                Xander Miller @xander-miller · 29 minutes ago
                Developer

                Worked for me. https://epic-transcoder-improvements.minds.io/newsfeed/1051533867887890442

              • Xander Miller @xander-miller approved this merge request 28 minutes ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 26 minutes ago
                Developer

                Several e2e test failures. I've seen newsfeed, plus and pro specs fail on other MRs. The upgrades spec is one I haven't noticed failing before.

                image

              • Mark Harding
                Mark Harding @markeharding · 5 minutes ago
                Owner

                Squashed to e2bf6f13

              • Mark Harding @markeharding closed 5 minutes ago

                closed

              Please register or sign in to reply
              0 Assignees
              None
              Transcoder Improvements
              Milestone
              Transcoder Improvements
              Time tracking
              No estimate or time spent
              4
              Labels
              Priority::1 - High Product::Media Squad::Blue Type::Refactor
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Emiliano Balbuena
              user avatar
              Ben Hayward
              user avatar
              Rami Albatal
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              Reference: minds/front!691