Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 404
  • Merge Requests 59
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !693

Open
Opened 10 minutes ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/UnderstoodUnicorn](fix): Fixed inability to cancel uploaded image. #2334

Summary

Closes #2334

This merge request addresses an issue on production right now where cancelling an image upload causes everything to break.

Steps to test

  1. Fully upload an image
  2. Cancel it
  3. It should cancel
  4. Upload a new image

Repeat but stop the image mid upload.

All should work fine.

Estimated Regression Scope

This change should affect media uploads across the site. Comments, feeds etc. There is an issue where-in you can get the poster to show no attachment after hitting upload - this occurs when it is waiting for the previous XHR to resolve.

Request to merge fix/attachment-poster-2334 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #102334811 running for 6d26c549 on fix/attachment-poster-2334
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Emiliano Balbuena
              Emiliano Balbuena
              Rami Albatal
              Rami Albatal
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2334

              Deletes source branch

              • Discussion 0
              • Commits 2
              • Pipelines 2
              • Changes 1
              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 10 minutes ago

                added scoped label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Xander Miller
              user avatar
              Emiliano Balbuena
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              Reference: minds/front!693