Summary

Pro user logo is not showing up for non-logged in users.

Steps to reproduce

1. Log out
2. Visit a pro page on its own subdomain (https://subverse.net/ for example).
3. Scroll down.
4. Observe no logo in pop-up.

Platform information

Cross-platform web

What is the current bug behavior?

Cannot see the users pro user logo.

What is the expected correct behavior?

Should be able to see the users logo.

Relevant logs and/or screenshots

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

/label ~"T - Bug" ~"S - Triage:new"

changed milestone to %Pro Beta #release

added scoped labels

added scoped label

assigned to @benhayward.ben

changed weight to 4

unassigned @markeharding

changed time estimate to 4h

added scoped label and automatically removed label

assigned to @markeharding

added scoped label and automatically removed label

unassigned @markeharding

changed the description

Hey @ottman two things:

a) What avatar should be showing. For me on my browser I see this:

b) Whats your browser?

Also if you can, a link to the page you're on in the screenshot above please

You should see the logo of the pro site.

Gotcha, thanks Bill.

added scoped label and automatically removed label

@ottman Within minds.com you're inside Minds, not the Pro site. That's why it has the Minds logo, because it'll take you to the Minds login/register screens.

It's not a bug. We already talked about how the popup should work before launch.

cc/ @brianhatchet @markeharding

Seems that the description steps and title don't match. Where's the exact issue?

Sorry Emi, there was little information to go on so I edited the description of this; the above may not be the correct reproducation steps. It appears to be happening on https://subverse.net/ and other domains.

Will update that now

changed the description

We need to stop the "Guess how to reproduce based on a screenshot" practice.

Looks to me like this.site.pro.logo_guid (taken from window.Minds.pro.logo_guid) is not populated.

Here's the line that outputs the breaking URL https://gitlab.com/minds/front/blob/5578edbbb74a5c16fbb9a25d7fa823781406c510/src/app/modules/modals/signup/signup.ts#L37

There's some entity hydration going on on the back-end that I believe should be adding this variable into Window.minds.pro, but is not there for Subverse and seemingly others on a pro domain looking at Bills screenshot above (though I have no other links to examples).

added 2h of time spent at 2019-12-05

removed label

added scoped label

the dual-modal bug mentioned above is here minds#981

mentioned in commit 842d83d7

mentioned in merge request !687

added scoped label and automatically removed label

added 6h of time spent at 2019-12-06

added scoped label

added scoped label and automatically removed label

added scoped label and automatically removed label

removed label

Currently getting the sandbox enviroment set up for testing

added scoped label