[Sprint/TrendyTurtle](fix): Pro logo sign-in modal fix #2289
Closes #2289
Summary:
This change behaves differently if you are on a subdomain.
https://subverse.net, vs https://www.minds.com/pro/subverse
Currently on production, on a subdomain, the logo of the pro user is supposed to show, but it does not. On a non sub-domain, the Minds logo is supposed to show up.
Issue's I'm aware of
There's two modals loading on non-subdomains. This looks a bit like a huge shadow. This is to be dealt with in another card here: minds#981
Steps to reproduce
Standard Minds domain
-
Give yourself a pro account a) log in. b) go to channel of the user you want to grant it to. c) hit the briefcase icon on the profile sidebar.
-
Verify your avatar is shown on the page
-
Scrolling down it not logged in, should show the minds logo.
-
Set a logo
-
Logo should show on page
-
Scroll down, modal should trigger and Minds Logo should still be shown.
On a subdomain
- /etc/hosts edit may need to be made on the sandbox, alternatively, speak with @edgebal, he may know a way to simulate it.
No pro user set, avatar still shown
On a subdomain
minds.com/pro/
added scoped label
- Developer
Well, for starters, I am unable to give myself a pro account on this review site. The current /pro page is broken and the console throws
TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null"
errors until it crashes
- Developer
Also, passing off issues onto the tests with a note to "figure it out" is unacceptable. If there's issues with the review sites that prevent testing, we need to get them sorted out and probably promote this to a Beatle's server in the mean time. But, it's your responsibility to get the resources ironed out so we can this properly.
On a subdomain
- /etc/hosts edit may need to be made on the sandbox, alternatively, speak with @edgebal, he may know a way to simulate it.
- Developer
Intended as less of a figure it out for yourself and more of a warning that it was considerable effort to do, and local testing would be preferred - that said if you want to go down that road we need:
a) A fresh domain and Minds hosted on an EC2 or write access to K8s pods.
b) A fresh domain and a helm mapping spawning 2 Traefik frontends.
Edited by Ben Hayward - Developer
Spoke with Emi, he is going to prepare the helm charts so that this can be tested on the sandboxes; may still need access to DNS.