Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 407
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !394

Open
Opened 5 months ago by Marcelo Rivera@eiennohi
Report abuse

[Sprint/HipsterHedgehog] (feat): ability to copy and paste images into posts and comments

closes minds#553

closes #2312

Edited 5 days ago by Marcelo Rivera
Request to merge feat/copy-and-paste-images-in-posts into master
The source branch is 10 commits behind the target branch
Open in Web IDE
Pipeline #100917682 passed with warnings for 7d7b9624 on feat/copy-and-paste-images-in-posts
              Requires approval from Deployers. Approved by
              Emiliano Balbuena
              Emiliano Balbuena
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Juan Manuel Solaro
              Juan Manuel Solaro
              Mark Harding
              Mark Harding
              Olivia Madrid
              Olivia Madrid
              Martin Santangelo
              Martin Santangelo
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2312 and minds#553

              Deletes source branch

              • Discussion 9
              • Commits 8
              • Pipelines 4
              • Changes 11
              1/1 thread resolved
              • Marcelo Rivera @eiennohi mentioned in merge request !374 (closed) 5 months ago

                mentioned in merge request !374 (closed)

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 5 months ago
                Resolved by Marcelo Rivera 5 months ago
              • Mark Harding @markeharding added MR::Awaiting Review scoped label 5 months ago

                added scoped label

              • Mark Harding
                Mark Harding @markeharding · 5 months ago
                Owner

                Confirmed this works. However, my copied gif no longer animates with copy/paste flow?

              • Mark Harding
                Mark Harding @markeharding · 5 months ago
                Owner

                Also confirm !394 (diffs, comment 187720495) and then we are good

              • Marcelo Rivera @eiennohi added 28 commits 5 months ago

                added 28 commits

                • 18d4f68c...82595d15 - 26 commits from branch master
                • f21330be - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts
                • c71558d1 - (fix): brought back e.preventDefault();

                Compare with previous version

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 5 months ago
                Developer

                @markeharding, I did some research and found out that copying and pasting gifs only captures the current frame. It works like that everywhere, I think

              • Marcelo Rivera @eiennohi resolved all discussions 5 months ago

                resolved all discussions

              • Mark Harding @markeharding added Squad::Yellow scoped label 4 months ago

                added scoped label

              • Marcelo Rivera @eiennohi mentioned in issue #2312 5 days ago

                mentioned in issue #2312

              • Marcelo Rivera @eiennohi changed the description 5 days ago

                changed the description

              • Marcelo Rivera @eiennohi added 539 commits 5 days ago

                added 539 commits

                • c71558d1...80e43c8c - 538 commits from branch master
                • 52206363 - Merge remote-tracking branch 'upstream/master' into feat/copy-and-paste-images-in-posts

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 5 days ago

                added 1 commit

                • 7d7b9624 - (fix): lint

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @edgebal and @xander-miller 4 days ago

                assigned to @edgebal and @xander-miller

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 4 days ago
                Developer

                Copy and paste into a post. Bam, it works great

              • Xander Miller
                Xander Miller @xander-miller · 3 days ago
                Developer

                Working for me too.

              • Xander Miller @xander-miller approved this merge request 3 days ago

                approved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 3 hours ago

                approved this merge request

              • Emiliano Balbuena @edgebal unapproved this merge request 3 hours ago

                unapproved this merge request

              • Emiliano Balbuena @edgebal approved this merge request 3 hours ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 3 hours ago
                Developer

                Works for me too. I couldn't delete the attachment, but it's an upstream issue.

              • Xander Miller
                Xander Miller @xander-miller · 3 minutes ago
                Developer

                Several failures on the e2e tests. I think these are getting fixed on other in coming merge requests though.

                image

              Please register or sign in to reply
              2 Assignees
              Emiliano Balbuena's avatar
              Xander Miller's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Rami Albatal
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Ben Hayward
              Reference: minds/front!394