Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 407
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !677

Merged
Opened 1 week ago by Emiliano Balbuena@edgebal
Report abuse

Allow period fallbacks on Discovery feeds

Testing

  • Go to https://goal-top-algorithm-redux-2.minds.io/newsfeed/global/top;period=12h
  • Check that the Posts older than 12H legend appears at some point, with older posts below
  • Play around with TOP and LATEST filters.

Note: Do not use HOT as it's running on the old votes-per-period system which isn't running on Sandboxes.

Devs: Refreshing Top posts list

  • Switch to Sandbox cluster
  • $ kubectl get pods | grep goal-top-algorithm-redux-2-minds-app
  • $ kubectl exec -ti goal-top-algorithm-redux-2-minds-app-{random_ID_HERE} sh
  • $ cd /var/www/Minds/engine
  • $ php cli.php top all sync_activity --metric=down --from=1 && php cli.php top all sync_activity --metric=up --from=1 && php cli.php top all sync_images --metric=down --from=1 && php cli.php top all sync_images --metric=up --from=1 && php cli.php top all sync_videos --metric=down --from=1 && php cli.php top all sync_videos --metric=up --from=1 && php cli.php top all sync_blogs --metric=down --from=1 && php cli.php top all sync_blogs --metric=up --from=1

Issues

  • Closes #2269 (closed)
Edited 5 days ago by Emiliano Balbuena
Request to merge goal/top-algorithm-redux-2 into master
Pipeline #101240961 passed with warnings for 1ea1f841 on goal/top-algorithm-redux-2
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Rami Albatal
              Rami Albatal
              Juan Manuel Solaro
              Juan Manuel Solaro
              Olivia Madrid
              Olivia Madrid
              Martin Santangelo
              Martin Santangelo
              Guy Thouret
              Guy Thouret
              All merge request dependencies have been merged (1 merged)

              Merged by Mark Harding 1 hour ago

              The changes were merged into master with f90c7262

              The source branch has been deleted

              Closed #2269 (closed)

              Pipeline #102025650 waiting for manual action for f90c7262 on master
                            • Discussion 6
                            • Commits 4
                            • Pipelines 4
                            • Changes 5
                            0/1 thread resolved
                            • Emiliano Balbuena @edgebal added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                              added scoped labels

                            • Emiliano Balbuena @edgebal changed milestone to %HILE Q4/2019 1 week ago

                              changed milestone to %HILE Q4/2019

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 637b88fb - (fix): Misaligned margin

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 6 days ago

                              added 1 commit

                              • 768c7a5f - (chore): Enable 1Y back

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 6 days ago

                              changed the description

                            • Emiliano Balbuena @edgebal mentioned in merge request engine!407 (merged) 6 days ago

                              mentioned in merge request engine!407 (merged)

                              • Brian Hatchet
                                Brian Hatchet :speech_balloon: @brianhatchet · 6 days ago
                                Developer

                                There's something funky up with the feed selectors.

                                When I hit this, with the query parameters, it works.

                                https://goal-top-algorithm-redux-2.minds.io/newsfeed/global/top;period=12h;all=1

                                When you navigate back to newsfeed and then back, however, you get nothing

                                Screen capture here https://www.screencast.com/t/G96AUFdUby

                                Edited by Brian Hatchet 5 days ago
                              • Collapse replies
                              • Brian Hatchet
                                Brian Hatchet :speech_balloon: @brianhatchet · 5 days ago
                                Developer

                                @edgebal pointed out that the preferred filter gets set to On when switching to discovery tab. It's not an issue for this card.

                              • Please register or sign in to reply
                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 5 days ago

                              approved this merge request

                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet · 5 days ago
                              Developer

                              @xander-miller Can you review this MR?

                            • Emiliano Balbuena
                              Emiliano Balbuena @edgebal · 5 days ago
                              Developer

                              As a heads up, @xander-miller, I liked a couple of media posts and re-ran the sync command. You should be able to use the type filter (all/images/videos/blogs)

                            • Emiliano Balbuena @edgebal changed the description 5 days ago

                              changed the description

                            • Xander Miller @xander-miller approved this merge request 4 days ago

                              approved this merge request

                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet · 4 days ago
                              Developer

                              @markeharding I don't have merge request rights to merge this in anymore.

                            • Brian Hatchet :speech_balloon: @brianhatchet assigned to @markeharding 4 days ago

                              assigned to @markeharding

                            • Mark Harding
                              Mark Harding @markeharding · 4 days ago
                              Owner

                              Screenshot_2019-12-06_at_05.37.27 This shouldn't show be showing when the feature flag is off.

                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 4 days ago

                              added scoped label and automatically removed label

                            • Emiliano Balbuena @edgebal added 1 commit 4 days ago

                              added 1 commit

                              • 1ea1f841 - (fix): Feature flag for "posts older" divider

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 1 hour ago

                              approved this merge request

                            • Mark Harding @markeharding merged 1 hour ago

                              merged

                            • Mark Harding @markeharding mentioned in commit f90c7262 1 hour ago

                              mentioned in commit f90c7262

                            Please register or sign in to reply
                            2 Assignees
                            Mark Harding's avatar
                            Emiliano Balbuena's avatar
                            HILE Q4/2019
                            Milestone
                            HILE Q4/2019
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Requires Changes Squad::Yellow
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Rami Albatal
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            user avatar
                            Guy Thouret
                            user avatar
                            Brian Hatchet
                            user avatar
                            Xander Miller
                            Reference: minds/front!677