Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 406
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !692

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](feat): Added in error message on socket connection breaking. #2115

Summary

Closes #2115 MR to add an error message in to show the user when their connection to live comments has been lost.

Steps to test

To discuss - may need to make some API endpoints so that we can trigger this on sandboxes.

Estimated Regression Scope

The worst-case scenario is are that something could break in sockets or thread comments. E.g. the error showing at inappropriate times if the error is for some reason called more times than necessary on prod, or maybe the load more of the comments thread.

Request to merge feat/socket-error-comments-2115 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
Pipeline #102021616 failed for 7c1778f5 on feat/socket-error-comments-2115
              Requires 3 more approvals from Devs, Deployers, and QA.
              Rami Albatal
              Rami Albatal
              Emiliano Balbuena
              Emiliano Balbuena
              Juan Manuel Solaro
              Juan Manuel Solaro
              Mark Harding
              Mark Harding
              Olivia Madrid
              Olivia Madrid
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2115

              Deletes source branch

              • Discussion 0
              • Commits 1
              • Pipelines 1
              • Changes 5
              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 1 hour ago

                added scoped label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Rami Albatal
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              Reference: minds/front!692