Skip to content

Minds Backend - Engine
Minds Backend - Engine
Open
Opened by Emiliano Balbuena@edgebal
Report abuse

Modernize Router (&75)

Testing

  • Basically the whole site should be functional. Don't forget to test uploads, avatar changes, deleting stuff, etc. Network activity on Dev Tools should behave as usual. Don't solely focus on AJAX (XHR) requests, /fs and the initial HTML document go thru it.

How do I know if I'm over the new router?

Check Response Headers in your Dev Tools. All the non-static requests should have a X-Route-Resolver: <value> header set. Also, window.Minds.features["psr7-router"] should be true.

Possible values are:

  • route-resolver: New Module-based Router. No endpoints are using this, yet.
  • pre-psr7: JSON API requests handled by old Router.
  • pre-psr7-static: HTML requests handled by old Router. Right now, the initial HTML request is the only one.

Issues

Edited by Emiliano Balbuena
Request to merge epic/modern-router into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #101273403 passed for c6bcee07 on epic/modern-router
          Requires 2 more approvals from Devs and Deployers.
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1143 (closed), #1177 (closed), #1189 (closed), and #882 (closed)

          Deletes source branch

          6/8 threads resolved
          Please register or sign in to reply