Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 405
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !687

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](fix): Pro logo sign-in modal fix #2289

Closes #2289

Summary:

This change behaves differently if you are on a subdomain.

https://subverse.net, vs https://www.minds.com/pro/subverse

Currently on production, on a subdomain, the logo of the pro user is supposed to show, but it does not. On a non sub-domain, the Minds logo is supposed to show up.

Issue's I'm aware of

There's two modals loading on non-subdomains. This looks a bit like a huge shadow. This is to be dealt with in another card here: minds#981

Steps to reproduce

Standard Minds domain

  1. Give yourself a pro account a) log in. b) go to channel of the user you want to grant it to. c) hit the briefcase icon on the profile sidebar.

  2. Verify your avatar is shown on the page

  3. Scrolling down it not logged in, should show the minds logo.

  4. Set a logo

  5. Logo should show on page

  6. Scroll down, modal should trigger and Minds Logo should still be shown.

On a subdomain

  1. /etc/hosts edit may need to be made on the sandbox, alternatively, speak with @edgebal, he may know a way to simulate it.
No pro user set, avatar still shown

image

On a subdomain

image

minds.com/pro/

image

Request to merge fix/pro-logo-modal-2289 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
Pipeline #101322576 passed with warnings for 8b6d2845 on fix/pro-logo-modal-2289
              Requires 3 more approvals from Devs, Deployers, and QA.
              Rami Albatal
              Rami Albatal
              Emiliano Balbuena
              Emiliano Balbuena
              Juan Manuel Solaro
              Juan Manuel Solaro
              Marcelo Rivera
              Marcelo Rivera
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2289

              Mentions minds#981

              Deletes source branch

              • Discussion 3
              • Commits 2
              • Pipelines 2
              • Changes 10
              0/2 threads resolved
              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 3 days ago

                added scoped label

              • Ben Hayward @benhayward.ben added 1 commit 3 days ago

                added 1 commit

                • 8b6d2845 - Tidying

                Compare with previous version

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 10 hours ago
                  Developer

                  Well, for starters, I am unable to give myself a pro account on this review site. The current /pro page is broken and the console throws

                  TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null" vendor.779a60b3ce201322a755.js:1:175272 TypeError: "this.minds.upgrades is null"

                  errors until it crashes

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 10 hours ago
                  Developer

                  Also, passing off issues onto the tests with a note to "figure it out" is unacceptable. If there's issues with the review sites that prevent testing, we need to get them sorted out and probably promote this to a Beatle's server in the mean time. But, it's your responsibility to get the resources ironed out so we can this properly.

                  On a subdomain

                  1. /etc/hosts edit may need to be made on the sandbox, alternatively, speak with @edgebal, he may know a way to simulate it.
                • Collapse replies
                • Ben Hayward
                  Ben Hayward @benhayward.ben · 1 hour ago
                  Developer

                  Intended as less of a 'figure it out for yourself' and more of a warning that it was considerable effort to do, and local testing would be preferred - that said if you want to go down that road we need:

                  a) A fresh domain and Minds hosted on an EC2 or write access to K8s pods.

                  b) A fresh domain and a helm mapping spawning 2 Traefik frontends.

                  Edited by Ben Hayward 1 hour ago
                • Please register or sign in to reply
              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Rami Albatal
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              Reference: minds/front!687