Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 406
  • Merge Requests 62
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !689

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](fix): Fixed pro spec test. #2310

Closes #2310

To test, check the pipeline down below or checkout this branch locally and run Cypress.

Request to merge fix/pro-marketting-2310 into master
The source branch is 4 commits behind the target branch
Open in Web IDE
Pipeline #101691963 passed with warnings for 72561c86 on fix/pro-marketting-2310
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Emiliano Balbuena
              Emiliano Balbuena
              Marcelo Rivera
              Marcelo Rivera
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2310

              Deletes source branch

              • Discussion 2
              • Commits 1
              • Pipelines 1
              • Changes 1
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 day ago

                added scoped labels

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 9 hours ago
                Developer

                @benhayward.ben can you explain your comment in the card?

                Pro tests are not supposed to run on sandboxes. I can, however, enable them if we can confirm sandbox & proudction are now running on prod / sandboxes

                We definitely need to get our e2e tests running on review sites for pro. What's the issue?

              • Ben Hayward
                Ben Hayward @benhayward.ben · 11 minutes ago
                Developer

                Sorry, may have typed too fast - They were initially skipped over because Pro sites were not working on the sandboxes, which they now are (I believe this was around the time the router changes were going in), so they need re-enabling and likely updating so they greenlight. Made a card for this here but I've left it in follow-up as it needs further breaking up. #2316

                This, however, is actually under the marketing banner so it is unrelated to that anyway, I hadn't realized at the time.

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Rami Albatal
              user avatar
              Emiliano Balbuena
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              Reference: minds/front!689