Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 405
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !676

Open
Opened 1 week ago by Marcelo Rivera@eiennohi
Report abuse

CR Product Pages

closes #2232

Request to merge fix/product-pages-design-2232 into master
The source branch is 13 commits behind the target branch
Open in Web IDE
Pipeline #100054556 passed with warnings for d051d0cb on fix/product-pages-design-2232
              Requires approval from QA. Approved by
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Emiliano Balbuena
              Emiliano Balbuena
              Ben Hayward
              Ben Hayward
              Mark Harding
              Mark Harding
              Martin Santangelo
              Martin Santangelo
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2232

              Deletes source branch

              • Discussion 5
              • Commits 6
              • Pipelines 2
              • Changes 24
              • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 1 week ago

                added scoped label

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label 1 week ago

                added scoped label

              • Mark Harding @markeharding assigned to @michaelfbradley 5 days ago

                assigned to @michaelfbradley

              • Mark Harding
                Mark Harding @markeharding · 5 days ago
                Owner

                @eiennohi please follow up with @michaelfbradley so knows how to test to give final approval so this can be merged in.

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

                approved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                Developer

                @michaelfbradley Please confirm that these product pages are good to go. @markeharding and @xander-miller need your approval as well.

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @xander-miller 1 day ago

                assigned to @xander-miller

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @markeharding 1 day ago

                assigned to @markeharding

              • Brian Hatchet :speech_balloon: @brianhatchet added Sprint::12/04 - Trendy Turtle scoped label 1 day ago

                added scoped label

              • Brian Hatchet :speech_balloon: @brianhatchet removed Sprint::12/04 - Trendy Turtle label 1 day ago

                removed label

              • Michael Bradley
                Michael Bradley @michaelfbradley · 1 day ago
                Developer

                Will do @brianhatchet @markeharding - Will review today.

              • Michael Bradley
                Michael Bradley @michaelfbradley · 46 minutes ago
                Developer

                General Product Page Feedback for large desktop screens

                • 1 - Radio Buttons not displaying correctly or functioning
                • 2 - text colour incorrect
                • 3 - Missing purchase CTA and total per month
                • 4 - header/nav should match designs
                • 5 - Missing logos
                • 6 - Footer should span the full width of the window
                • 7 - Size of this polygon doesn’t full match designs

                Product_Page__PRO__Desktop__Review

                cc @eiennohi @markeharding

              • Michael Bradley
                Michael Bradley @michaelfbradley · 28 minutes ago
                Developer

                Responsive Issues

                Not enough design consideration was given to the responsive nature of these pages. A medium sized view will need to be introduced. Moving forward, all pages will adapt across large, medium and small screens.

                Breakpoints

                The breakpoints for the responsive layout should be as follows.

                • Small screen <= 576px
                • Medium screen <= 922px
                • Large screen > 922px

                Medium screen designs have been added to InVision. Multiple variations have been added to illustrate how the pages should look like across various sizes.

                • 900px wide - https://invis.io/KWU1X9IEB2U#/397088238_Product_Page_-PRO--Medium_900-
                • 700px wide - https://invis.io/KWU1X9IEB2U#/397088237_Product_Page_-PRO--Smaller_Medium_700-
                • 600px wide - https://invis.io/KWU1X9IEB2U#/397088236_Product_Page_-PRO--Smaller_Medium_600-

                Getting the responsive layout to function correctly for medium design will involve using margins/paddings/font-sizes/line-heights etc relative to the view width.

                For example, See see the current state of the product pages at 600px wide.

                Screenshot_2019-12-10_at_11.16.57

                Screenshot_2019-12-10_at_11.17.03

                cc @eiennohi @brianhatchet @markeharding

              Please register or sign in to reply
              3 Assignees
              Mark Harding's avatar
              Xander Miller's avatar
              Michael Bradley's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              12
              12 participants
              user avatar
              Rami Albatal
              user avatar
              Emiliano Balbuena
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              Reference: minds/front!676