Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 405
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !684

Open
Opened 3 days ago by Marcelo Rivera@eiennohi
Report abuse

Error in video player (sentry)

closes #2234

Couldn't really reproduce this one, but looking at the code I can see that the progressbar only gets rendered when there's a reference to the video player (playerRef), and the error occurs inside a setTimeout, so it could be possible that for some reason that the player is no longer there when the timeout executes.

Request to merge fix/sentry-issue-2234 into master
The source branch is 8 commits behind the target branch
Open in Web IDE
Pipeline #101189121 passed with warnings for 70ee32f9 on fix/sentry-issue-2234
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Emiliano Balbuena
              Emiliano Balbuena
              Ben Hayward
              Ben Hayward
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2234

              Deletes source branch

              • Discussion 1
              • Commits 2
              • Pipelines 1
              • Changes 3
              • Marcelo Rivera @eiennohi added MR::Awaiting Review Squad::Yellow scoped labels 3 days ago

                added scoped labels

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 10 minutes ago
                Developer

                I can't even upload a video to test to this environment because the settings for the max video size and max video length are set to zero.

                Please, update the helm configuration for this review site so we can make sure the code doesn't break anything, at least.

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Rami Albatal
              user avatar
              Emiliano Balbuena
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Olivia Madrid
              Reference: minds/front!684