Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 405
  • Merge Requests 61
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !680

Open
Opened 5 days ago by Olivia Madrid@omadrid0 of 8 tasks completed0/8 tasks
Report abuse

Token balance component

Description Refactor existing token balance component to match UX design: https://projects.invisionapp.com/share/KWU1X9IEB2U#/screens/396034060

Still need to do fine-tuning for mobile widths but will do that another time.

Also added a bunch of stuff to the service while I was at it. But only the getWallet() function is really being used.

Testing Not particularly feasible in it's current state of staging limitations. Theoretically, testing should be like this:

  • Navigate to /v2wallet
  • Token balances (total, offchain & onchain) should be accurate.
  • The "buy tokens" button should be disabled if you haven't set up your wallet yet
  • "buy tokens" and "learn more about tokens" should navigate to /tokens
  • The "transfer to on-chain" link should not appear if you haven't set up your wallet yet
  • Estimated token payout value and time of next payout should be accurate
  • The estimated token payout element should not be visible on mobile
  • Ensure accuracy of tokens/usd/eth subtotal values returned by walletService.getWallet()

Note: "transfer to on-chain" doesn't do anything

Closes #2282

Part of &80

Edited 4 hours ago by Olivia Madrid
Request to merge tokens-balance-2282 into epic/wallet-80
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #101848754 passed with warnings for 5a5db254 on tokens-balance-2282
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Emiliano Balbuena
              Emiliano Balbuena
              Marcelo Rivera
              Marcelo Rivera
              Ben Hayward
              Ben Hayward
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request
              • Discussion 10
              • Commits 7
              • Pipelines 7
              • Changes 64
              0/6 threads resolved
              • Olivia Madrid @omadrid added Product::Wallet Squad::Blue scoped labels 5 days ago

                added scoped labels

              • Olivia Madrid @omadrid added 1 commit 3 days ago

                added 1 commit

                • c45fd44f - (feat): wallet balance tokens and service updates

                Compare with previous version

              • Olivia Madrid @omadrid added 1 commit 6 hours ago

                added 1 commit

                • 5cca6a47 - (feat): wallet token balance and service adjustments

                Compare with previous version

              • Olivia Madrid @omadrid added 9 commits 6 hours ago

                added 9 commits

                • 5cca6a47...8615ed34 - 2 commits from branch epic/wallet-80
                • 0ed904cc - (fix): show pro settings placeholder dragdrop when empty
                • 44ca320e - Preferred hashtag remembered in local storage #1366 (closed)
                • 2e8a9896 - Merge branch 'feat/default-disc-tags-1366' into 'master'
                • f44bd1ff - Sprint/TrendyTurtle: Blogs E2E test fix
                • 4a7c4f12 - Merge branch 'fix/blogs-e2e-2308' into 'master'
                • 017195d1 - Merge branch 'show-hashtag-placeholder' into 'master'
                • 3ac17882 - Merge branch 'master' of gitlab.com:minds/front into tokens-balance-2282

                Compare with previous version

                Toggle commit list
              • Olivia Madrid @omadrid added 1 commit 6 hours ago

                added 1 commit

                • 8e67036f - (feat): don't get fake wallet data from service

                Compare with previous version

              • Olivia Madrid @omadrid changed the description 6 hours ago

                changed the description

              • Olivia Madrid @omadrid added 1 commit 5 hours ago

                added 1 commit

                • 37ce3522 - (feat): uncomment some template logic

                Compare with previous version

              • Olivia Madrid @omadrid added 1 commit 4 hours ago

                added 1 commit

                • 5a5db254 - (feat): add router link to 'learn more' button

                Compare with previous version

              • Olivia Madrid @omadrid changed the description 4 hours ago

                changed the description

              • Olivia Madrid @omadrid unmarked as a Work In Progress 4 hours ago

                unmarked as a Work In Progress

              • Olivia Madrid @omadrid changed title from WIP: token balance component to Token balance component 4 hours ago

                changed title from oken balance component to oken balance component

              • Olivia Madrid @omadrid changed milestone to %Wallet Upgrade 4 hours ago

                changed milestone to %Wallet Upgrade

              • Olivia Madrid @omadrid added MR::Awaiting Review scoped label 4 hours ago

                added scoped label

              • Olivia Madrid @omadrid changed the description 4 hours ago

                changed the description

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @eiennohi 32 minutes ago

                assigned to @eiennohi

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 29 minutes ago
                  Developer

                  Tokens, USD, Ether, Bitcoin need a 24 px line height, they are 444444 on the review site, but are 4A4A4A

                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 26 minutes ago
                  Developer

                  Your Wallet h3, needs to be 24 px font weight and 32 px line height

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 28 minutes ago
                  Developer

                  Too much space between token balance header and balance

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 28 minutes ago
                  Developer

                  Transfer to On-Chain link missing on the Token page

                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 26 minutes ago
                  Developer

                  "Today's estimated payout" is different that the "Daily estimated payout" on the mocks

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 27 minutes ago
                  Developer

                  Overview graph filters don't match the mocks. 1W instead of 7D 1M instead of 30D No 3 M 1Y instead of 12M No Max button

                  Graph nodes are blue circles instead of white ones (minus the hover over range)

                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 26 minutes ago
                  Developer

                  Precision of the hover card for the tokens is off, needs to be .00

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 27 minutes ago
                  Developer

                  Does the Y Axis support the "140K" format?

                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 26 minutes ago
                  Developer

                  Please up the mocks in Invision inspect. You can access to all sorts of information and extract the css with a click. https://projects.invisionapp.com/d/main/#/console/18532170/396034060/inspect

                • Please register or sign in to reply
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 26 minutes ago
                  Developer

                  @eiennohi can you please handle the code side of things. Easiest if one of us reviews the UI and the other does the code. It looks pretty clean to me

                • Please register or sign in to reply
              Please register or sign in to reply
              Assignee
              Marcelo Rivera's avatar
              Marcelo Rivera @eiennohi
              Wallet Upgrade
              Milestone
              Wallet Upgrade
              Time tracking
              No estimate or time spent
              3
              Labels
              MR::Awaiting Review Product::Wallet Squad::Blue
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Rami Albatal
              user avatar
              Emiliano Balbuena
              user avatar
              Marcelo Rivera
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              Reference: minds/front!680