Preferred hashtag remembered in local storage #1366
Closes #1302 (closed)
Test that your selection for preferred is remembered in local storage.
- Set it to on
- Tab over to wallet or another page
- Refresh
- Visit discovery - it should have remembered the state was on.
- Turn it off, and repeat to confirm that is remembers the 'off' state
added scoped labels
added scoped label and automatically removed label
- Owner
This is now no longer defaulting to preferred by default.
added scoped label and automatically removed label
- Owner
added scoped label and automatically removed label
- Developer
Looked into this today, that bug is present on production also; and furthermore, this is happening (which it is not in this MR) #2240 (closed)
- Owner
Thats seems to be a different issue. Here you have 'preferred' set to off, but you are not passing
all=1
. There is not subsequent XHR request to be made. added 90 commits
-
15db3ac9...6ad11c19 - 86 commits from branch
master
- 57a897da - Merge branch 'master' of gitlab.com:minds/front into feat/default-disc-tags-1366
- fd50b273 - Merge branch 'master' of gitlab.com:minds/front into feat/default-disc-tags-1366
- 77f61c90 - Merge branch 'master' of gitlab.com:minds/front into feat/default-disc-tags-1366
- ca24fc35 - Fixed issue with all not being respected
Toggle commit list-
15db3ac9...6ad11c19 - 86 commits from branch
approved this merge request
assigned to @xander-miller
assigned to @edgebal
- Developer
Issue detected by @markeharding is still present. When you disable preferred state, navigate away, and then back. The URL on the browser lacks the
;all=1
part which is what the component uses to know if it should fetch the complete result set.Edited by Emiliano Balbuena assigned to @benhayward.ben
- Developer
Follow up: XHR is fetching the results correctly (
&all=X
is being correctly set). Only the permalink is missing the;all=1
fragment. approved this merge request
- Developer
Looks good. Compared it to staging could see the different functionality.
merged
mentioned in commit 2e8a9896