Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 403
  • Merge Requests 60
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !687

Open
Opened 6 hours ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/TrendyTurtle](fix): Pro logo sign-in modal fix #2289

Closes #2289

Summary:

This change behaves differently if you are on a subdomain.

https://subverse.net, vs https://www.minds.com/pro/subverse

Currently on production, on a subdomain, the logo of the pro user is supposed to show, but it does not. On a non sub-domain, the Minds logo is supposed to show up.

Issue's I'm aware of

There's two modals loading on non-subdomains. This looks a bit like a huge shadow. This is to be dealt with in another card here: minds#981

Steps to reproduce

Standard Minds domain

  1. Give yourself a pro account a) log in. b) go to channel of the user you want to grant it to. c) hit the briefcase icon on the profile sidebar.

  2. Verify your avatar is shown on the page

  3. Scrolling down it not logged in, should show the minds logo.

  4. Set a logo

  5. Logo should show on page

  6. Scroll down, modal should trigger and Minds Logo should still be shown.

On a subdomain

  1. /etc/hosts edit may need to be made on the sandbox, alternatively, speak with @edgebal, he may know a way to simulate it.
No pro user set, avatar still shown

image

On a subdomain

image

minds.com/pro/

image

Request to merge fix/pro-logo-modal-2289 into master
Open in Web IDE
Pipeline #101322576 passed with warnings for 8b6d2845 on fix/pro-logo-modal-2289
              Requires 3 more approvals from Devs, Deployers, and QA.
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Olivia Madrid
              Olivia Madrid
              Martin Santangelo
              Martin Santangelo
              Emiliano Balbuena
              Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2289

              Mentions minds#981

              Deletes source branch

              • Discussion 0
              • Commits 2
              • Pipelines 2
              • Changes 10
              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 6 hours ago

                added scoped label

              • Ben Hayward @benhayward.ben added 1 commit 6 hours ago

                added 1 commit

                • 8b6d2845 - Tidying

                Compare with previous version

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Brian Hatchet
              user avatar
              Rami Albatal
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              user avatar
              Emiliano Balbuena
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              Reference: minds/front!687