Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 404
  • Merge Requests 58
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !623

Open
Opened 1 month ago by Marcelo Rivera@eiennohi
Report abuse

Homepage redesign

closes https://gitlab.com/minds/ux/issues/2 closes #2112 closes #2313

Testing

  • logged out, go to the homepage. There's a 50/50 chance that you will either see a mobile phone on the right, or the register form. You can change it manually by modifying the experiment key in the local storage from 'base' to 'form' and vice-versa.
  • everything should look like in Michael's designs, for mobile, tablets and desktop.

If you're on the homepage version with the mobile phone:

  • "Join Minds Now" buttons should redirect to /onboarding where you'll only see the registration form.
  • Registering should go to the next step for onboarding
  • Skipping this should redirect you to homepage

If you're on the homepage version with the register form:

  • Registering should redirect to the first step of the onboarding
  • Skipping it should redirect to newsfeed

Testing the onboarding steps TBD

depends on engine!395

Edited 1 day ago by Marcelo Rivera
Request to merge feat/homepage-redesign into master
The source branch is 26 commits behind the target branch
Open in Web IDE
Pipeline #98459842 passed with warnings for fd2de775 on feat/homepage-redesign
              Requires 3 more approvals from Devs, Deployers, and QA.
              Rami Albatal
              Rami Albatal
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Guy Thouret
              Guy Thouret
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2112 and #2313

              Deletes source branch

              • Discussion 37
              • Commits 65
              • Pipelines 27
              • Changes 36
              10/11 threads resolved
              • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 1 month ago

                added scoped label

              • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                added 1 commit

                • b1936251 - (fix): fixed citation alignment

                Compare with previous version

              • Marcelo Rivera @eiennohi changed the description 1 month ago

                changed the description

              • Marcelo Rivera @eiennohi added 1 commit 1 month ago

                added 1 commit

                • 71354415 - (feat): update topbar design

                Compare with previous version

              • Marcelo Rivera @eiennohi added 7 commits 3 weeks ago

                added 7 commits

                • 4c3d6e23 - (feat): renamed HomepageComponent to HomepageV1Component
                • 5be586b4 - (fix): no background colour for the form
                • 8484f94e - (feat): responsive design for register form and top-left corner decoration
                • 867ec072 - (fix): several styling fixes for mobile resolution
                • 2afc5b4f - (fix): app buttons
                • 11be027c - (feat): added m-grid__column__skip-#{$i} for desktop and mobile
                • 507c3221 - (fix): quotation and links styling fixes

                Compare with previous version

                Toggle commit list
              • Marcelo Rivera @eiennohi added 74 commits 3 weeks ago

                added 74 commits

                • 507c3221...35070b4f - 73 commits from branch master
                • cc521451 - Merge remote-tracking branch 'upstream/master' into feat/homepage-redesign

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                added 1 commit

                • bd99718e - (fix): added images that got deleted while merging master

                Compare with previous version

              • Marcelo Rivera @eiennohi added 3 commits 3 weeks ago

                added 3 commits

                • f8ab05ee - (feat): add more margin-top to as featured in
                • 7c4044f3 - (fix): stylings for gray thingy in the first panel
                • 0287f55e - (feat): merge designs

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                added 1 commit

                • 69174e34 - (feat): merge designs

                Compare with previous version

              • Marcelo Rivera @eiennohi mentioned in merge request engine!395 3 weeks ago

                mentioned in merge request engine!395

              • Marcelo Rivera @eiennohi unmarked as a Work In Progress 3 weeks ago

                unmarked as a Work In Progress

              • Marcelo Rivera @eiennohi changed title from WIP: New homepage design to Homepage redesign 3 weeks ago

                changed title from design to design

              • Marcelo Rivera @eiennohi changed the description 3 weeks ago

                changed the description

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label 3 weeks ago

                added scoped label

              • Marcelo Rivera @eiennohi marked as a Work In Progress 3 weeks ago

                marked as a Work In Progress

              • Marcelo Rivera @eiennohi added 2 commits 3 weeks ago

                added 2 commits

                • 9e1a8a28 - (fix): layout tweaks
                • 701bc989 - (feat): stylings for tablets

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • ecd06913 - (feat): stylings for tablets

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • dec3617e - (feat): stylings for tablets

                Compare with previous version

              • Marcelo Rivera @eiennohi added 11 commits 2 weeks ago

                added 11 commits

                • dec3617e...a0d1737e - 10 commits from branch master
                • 57e73e13 - Merge remote-tracking branch 'upstream/master' into feat/homepage-redesign

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • 18ccfa82 - (feat): popover for password validation

                Compare with previous version

              • Marcelo Rivera @eiennohi changed the description 2 weeks ago

                changed the description

              • Marcelo Rivera @eiennohi added 17 commits 2 weeks ago

                added 17 commits

                • 18ccfa82...32c47ab2 - 13 commits from branch master
                • 76833369 - (feat): remove last section and correct items in "our principles"
                • fb30ca6f - (feat): add join button
                • dbe902ab - (fix): tringle thingy
                • 011c75d7 - Merge remote-tracking branch 'upstream/master' into feat/homepage-redesign

                Compare with previous version

                Toggle commit list
              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • 19edd595 - (fix): lint

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 2 weeks ago

                added 1 commit

                • 3607b826 - (fix): "Join Minds Now" on the bottom should only appear for base experiment

                Compare with previous version

              • Marcelo Rivera @eiennohi unmarked as a Work In Progress 2 weeks ago

                unmarked as a Work In Progress

              • Marcelo Rivera @eiennohi added 3 commits 1 week ago

                added 3 commits

                • fafb747d - (feat): add in support for multiple experiments in a single element
                • e1930348 - (feat): added in new homepage experiments
                • 1afe3d6f - (fix): spec tests and types

                Compare with previous version

                • Bill Ottman
                  Bill Ottman :dragon_face: @ottman · 1 week ago
                  Developer

                  Link? ;)

                • Collapse replies
                • Mark Harding
                  Mark Harding @markeharding · 1 week ago
                  Owner

                  Click 'View App' above. Screen_Shot_2019-11-24_at_3.41.15_AM

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Mark Harding 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Mark Harding 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 week ago
                Resolved by Marcelo Rivera 1 week ago
                • Mark Harding
                  Mark Harding @markeharding · 1 week ago
                  Owner
                  Resolved by Marcelo Rivera 1 week ago

                  @michaelfbradley Why are we using a different green on the homepage to elsewhere?

                • Michael Bradley
                  Michael Bradley
                  Mark Harding
                  Mark Harding
                  Last reply by Mark Harding 1 week ago
              • Mark Harding
                Mark Harding @markeharding · 1 week ago
                Owner

                @eiennohi there looks to be lots of discrepancies between implementation and mockup. Also the AB testing does not appear to be working at all. Please revert those changes.

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • 3f3f6fb9 - (fix): reverted latest experiment changes

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • 09e8059c - (fix): reverted lint on tasks/extract.i18n.xlf.ts

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • 2d72a854 - (fix): use old minds-form-register

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • c8d26f1c - (fix): don't use document for accessing the topbar

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding · 1 week ago
                Owner

                The topbar is not consistent with the mockups either and appears unfinished. Screenshot_2019-11-25_at_09.53.14. Also the margins of the bulb and the signups buttons appear to be off.

                Edited by Mark Harding 1 week ago
              • Mark Harding
                Mark Harding @markeharding · 1 week ago
                Owner

                I am unable to get the A/B testing platform to work without a manual override of the local storage. Does it work for you @eiennohi ?

                Screenshot_2019-11-25_at_10.01.28

                Screenshot_2019-11-25_at_10.01.19.

                There is a major discrepancy between this form and the one in mockup. These need to be pixel perfect.

                Edited by Mark Harding 1 week ago
              • Mark Harding
                Mark Harding @markeharding · 1 week ago
                Owner

                Form is not responsive Screenshot_2019-11-25_at_10.22.29

              • Marcelo Rivera @eiennohi mentioned in issue #2286 1 week ago

                mentioned in issue #2286

              • Marcelo Rivera @eiennohi added 3 commits 1 week ago

                added 3 commits

                • 8e5f719a - (fix): register form
                • 505830c2 - (fix): update download app buttons
                • 2a65381c - (fix): re-exported cellphone image

                Compare with previous version

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • fd2de775 - (fix): re-exported cellphone image

                Compare with previous version

              • Marcelo Rivera @eiennohi changed the description 1 day ago

                changed the description

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @eiennohi 16 hours ago

                assigned to @eiennohi

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @michaelfbradley 16 hours ago

                assigned to @michaelfbradley

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 16 hours ago
                Developer

                @michaelfbradley please, provide your feedback here.

              • Michael Bradley
                Michael Bradley @michaelfbradley · 1 hour ago
                Developer

                Here are some general notes relating to the larger, desktop view of the homepage (with phone graphic).

                See attached design for reference.

                • 1 - On wider screens, the above yellow shape should continue to grow with the page
                • 2 - The light blue/purple shape should also grow so its full width of the viewport.
                • 3 - Remove 1px spacing at top of yellow triangle
                • 4 - Header should be relatively positioned. i.e. it should scroll with the page.
                • 5 - The size and styling of the phone graphic isn't quite right. See notes.
                • 6 - text sizing and spacing is incorrect.
                • 7 - The text styling of the 'Wired' quote doesn't match the designs correctly.

                cc @eiennohi

                Note: Consider using Pixel Perfect (https://chrome.google.com/webstore/detail/perfectpixel-by-welldonec/dkaagdgjmgdmbnecmcefdhjekcoceebi) or something similar to overlay original designs with your browser. Great way to catch little issues like this.

                I'll do another review now for the mobile (small) screen.

                I will need to provide you with a design for medium screens. Currently we are going from large to small, but ideally this should be large -> medium -> small.

                Home_Page__B__Notes

              • Michael Bradley
                Michael Bradley @michaelfbradley · 43 minutes ago
                Developer

                See below notes and attached images review the mobile responsive view of the new homepage.

                • 1 - Remove footer/navigation. This shouldn't be visible on the homepage.
                • 2 - Styling and positioning issues related to the iPhone image.
                • 3 - Font size of 'Join Minds Now' button should be modified to match designs.
                • 4 - Spacing between the Download App icons should be reduced slightly
                • 5 - Text styling at top of page needs correcting
                • 6 - the positioning and colouring of the links in the header should be modified to match the designs.
                • 7 - The 'Wired' quote text needs to be styled accordingly.
                • 8 - Spacing under the wired quote to be reduced to match designs.
                • 9 - reduce spacing - see attached image for further context
                • 10 - 'Our principals' text styling and width needs to be addressed.
                • 11 - 'Take Back Control' call to action at the bottom of the page needs addressing.
                • 12 - Minds logo should be brought to the top if the footer.

                Homepage_-_mobile_responsive_notes

                cc @eiennohi

                Edited by Michael Bradley 43 minutes ago
              • Michael Bradley
                Michael Bradley @michaelfbradley · 39 minutes ago
                Developer
                • Can we possibly introduce a min-width of 320px to the page container, so we avoid the page getting necessarily squashed like this.

                Screenshot_2019-12-06_at_16.37.02

                cc @eiennohi

              • Michael Bradley
                Michael Bradley @michaelfbradley · 38 minutes ago
                Developer

                Is there a way I can access the other variation of the homepage, the one with the signup form on the page itself?

                cc @markeharding @eiennohi

              Please register or sign in to reply
              2 Assignees
              Marcelo Rivera's avatar
              Michael Bradley's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              14
              14 participants
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              Reference: minds/front!623