[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936
Closes front#1936 (closed)
Depends on front!613 (merged)
Summary
This change moves future blogs and media posts from the mature blog system, to the NSFW blog system. When creating a new blog. When editing existing values must be shown.
- The selection should propagate to the media entity.
- Changes via edit should also propegate
Testing
- Make video post with NSFW
- Edit the activity and change the NSFW tags to other, so that the mask goes away
- Refresh, see no mask
- Go to the media page for the actiity, and edit to Pornography.
- Checking back widgets, activity and blog post should have updated with flag.
Repeat for posting standard text posts, images and blogs.
Issues I'm aware of
- The pre-existing value for the NSFW selector is not respected, it must be clicked before it will register something as NSFW.
- Live update of NSFW in sidebar widgets - I would prefer to leave this out of this, and add that in at a later date. With the amount of testing involved change-detection fixes are not something I want to add into the mix.
- Image posts are not propagating to sidebar widget; handled here #1150 Blogs and Video should be
- Comments are still on the mature system - that is out of scope of this change.
added scoped labels
changed the description
mentioned in merge request front!613 (merged)
added 6 commits
-
c58d6ffc...4d188166 - 4 commits from branch
master - 14a2be02 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
- 1825a459 - Blog to activity propegation fix.
-
c58d6ffc...4d188166 - 4 commits from branch
marked as a Work In Progress
added scoped label and automatically removed label
unmarked as a Work In Progress
changed the description
added scoped label and automatically removed label
added scoped label and automatically removed label
added scoped label and automatically removed label
assigned to @xander-miller
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Owner@xander-miller please give approval when you are happy with this.
approved this merge request
unapproved this merge request
approved this merge request
approved this merge request
- Owner
I am unable to test as I have a 500 error.
[19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "NOTICE: PHP message: Exception #1574156970: Error: Call to a member function getContext() on boolean in /var/www/Minds/front/dist/en/index.php:4" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "Stack trace:" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#0 /var/www/Minds/engine/Core/I18n/I18n.php(123): include()" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#1 /var/www/Minds/engine/Core/Router.php(166): Minds\Core\I18n\I18n->serveIndex()" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#2 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route()" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#3 {main}" 127.0.0.1 - 19/Nov/2019:09:49:30 +0000 "GET /index.php" 500 - Developer
This was a sandbox issue that got sorted out.
added scoped label and automatically removed label
added 61 commits
-
7c02251e...52a592b9 - 59 commits from branch
master - 7cedf6a3 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
- cf9b88dc - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
-
7c02251e...52a592b9 - 59 commits from branch
DeveloperPulled in master, should reset the backend and resolve that.
![Xander Miller](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
Developer@markeharding test sandbox is back up. You can try reviewing again.
added 1 commit
- 4f78a38e - Updated to support old-style mature flagged blogs
added scoped label and automatically removed label
approved this merge request
- Developer
I tested this with Ben's latest changes and am pleased to report it works. I can edit a blog, mark it NSFW and have it propagate changes. On Monday, we'll get it up on of the Beatles servers and give it a proper test with live data.
approved this merge request
- Developer
Hi @markeharding, during yellow squad meeting today, we heard you have some concerns about the NSFW changes. I think that is in reference to this merge request. Could you add some review notes so we know what to fix / look out for when testing?
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
added scoped label and automatically removed label
added 35 commits
-
4f78a38e...4fb65001 - 34 commits from branch
master - ba297a25 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
-
4f78a38e...4fb65001 - 34 commits from branch
- Resolved by Brian Hatchet
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Ben Hayward
added 5 commits
-
587ee91b...fa6047ce - 4 commits from branch
master - 3af064a0 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
-
587ee91b...fa6047ce - 4 commits from branch
added scoped label and automatically removed label
changed the description
added scoped label and automatically removed label
approved this merge request
merged
mentioned in commit 6a88c337
- Developer
Couldn't find a media post view for blogs but other than that testing instructions were easy to follow.
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}
