Skip to content

Minds Frontend
Minds Frontend
Merged
Opened by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936

Closes #1936 (closed)

Depends on engine!384 (merged)

Summary

This change moves future blogs and media posts from the mature blog system, to the NSFW blog system. When creating a new blog. When editing existing values must be shown.

  • The selection should propagate to the media entity.
  • Changes via edit should also propegate

Testing

  1. Make video post with NSFW
  2. Edit the activity and change the NSFW tags to other, so that the mask goes away
  3. Refresh, see no mask
  4. Go to the media page for the actiity, and edit to Pornography.
  5. Checking back widgets, activity and blog post should have updated with flag.

Repeat for posting standard text posts, images and blogs.

Issues I'm aware of

  • The pre-existing value for the NSFW selector is not respected, it must be clicked before it will register something as NSFW.
  • Live update of NSFW in sidebar widgets - I would prefer to leave this out of this, and add that in at a later date. With the amount of testing involved change-detection fixes are not something I want to add into the mix.
  • Image posts are not propagating to sidebar widget; handled here engine#1150 Blogs and Video should be
  • Comments are still on the mature system - that is out of scope of this change.
Edited by Ben Hayward
Request to merge fix/blog-media-nsfw-update-1936 into master
Pipeline #100970889 passed with warnings for 773e0cb3 on fix/blog-media-nsfw-update-1936
              Merge request approved. Approved by
              Xander Miller Mark Harding Brian Hatchet

              Merged by Xander Miller

              The changes were merged into master with 8615ed34

              The source branch has been deleted

              Closed #1936 (closed)

              Mentions engine#1150

              Pipeline #101202449 waiting for manual action for 8615ed34 on master
                            8/8 threads resolved
                            Please register or sign in to reply