Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 403
  • Merge Requests 58
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !645

Open
Opened 4 weeks ago by Ben Hayward@benhayward.ben
Report abuse

Preferred hashtag remembered in local storage #1366

Closes #1302

Test that your selection for preferred is remembered in local storage.

  1. Set it to on
  2. Tab over to wallet or another page
  3. Refresh
  4. Visit discovery - it should have remembered the state was on.
  5. Turn it off, and repeat to confirm that is remembers the 'off' state
Request to merge feat/default-disc-tags-1366 into master
The source branch is 3 commits behind the target branch
Open in Web IDE
Pipeline #101009312 passed with warnings for d2ba1e1b on feat/default-disc-tags-1366
              Requires approval from QA. Approved by
              Brian Hatchet
              Brian Hatchet
              Rami Albatal
              Rami Albatal
              Marcelo Rivera
              Marcelo Rivera
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Guy Thouret
              Guy Thouret
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1302

              Mentions #1366 (closed)

              Deletes source branch

              • Discussion 6
              • Commits 8
              • Pipelines 5
              • Changes 3
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 4 weeks ago

                added scoped labels

              • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 4 weeks ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 4 weeks ago
                Owner

                This is now no longer defaulting to preferred by default.

              • Ben Hayward @benhayward.ben added 1 commit 4 weeks ago

                added 1 commit

                • 15db3ac9 - Default to true

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 4 weeks ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 3 weeks ago
                Owner

                Still issues here @benhayward.ben.

                Screen_Shot_2019-11-12_at_9.18.40_AM

                The XHR request is returning preferred when it should be all.

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

                added scoped label and automatically removed label

              • Ben Hayward
                Ben Hayward @benhayward.ben · 3 weeks ago
                Developer

                Looked into this today, that bug is present on production also; and furthermore, this is happening (which it is not in this MR) #2240 (closed)

              • Mark Harding
                Mark Harding @markeharding · 2 weeks ago
                Owner

                Thats seems to be a different issue. Here you have 'preferred' set to off, but you are not passing all=1. There is not subsequent XHR request to be made.

              • Ben Hayward @benhayward.ben added 90 commits 1 day ago

                added 90 commits

                • 15db3ac9...6ad11c19 - 86 commits from branch master
                • 57a897da - Merge branch 'master' of gitlab.com:minds/front into feat/default-disc-tags-1366
                • fd50b273 - Merge branch 'master' of gitlab.com:minds/front into feat/default-disc-tags-1366
                • 77f61c90 - Merge branch 'master' of gitlab.com:minds/front into feat/default-disc-tags-1366
                • ca24fc35 - Fixed issue with all not being respected

                Compare with previous version

                Toggle commit list
              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • eb4110bd - Minor change

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 20 hours ago

                added 1 commit

                • d2ba1e1b - Switching default value to off

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 15 hours ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @xander-miller 15 hours ago

                assigned to @xander-miller

              • Brian Hatchet :speech_balloon: @brianhatchet assigned to @edgebal 15 hours ago

                assigned to @edgebal

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 1 hour ago
                Developer

                Issue detected by @markeharding is still present. When you disable preferred state, navigate away, and then back. The URL on the browser lacks the ;all=1 part which is what the component uses to know if it should fetch the complete result set.

                Edited by Emiliano Balbuena 1 hour ago
              • Emiliano Balbuena @edgebal assigned to @benhayward.ben 1 hour ago

                assigned to @benhayward.ben

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 1 hour ago
                Developer

                Follow up: XHR is fetching the results correctly (&all=X is being correctly set). Only the permalink is missing the ;all=1 fragment.

              Please register or sign in to reply
              3 Assignees
              Emiliano Balbuena's avatar
              Xander Miller's avatar
              Ben Hayward's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Rami Albatal
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Emiliano Balbuena
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              Reference: minds/front!645