(cache)Refactor Boost Code (!410) · Merge Requests · Minds / Minds Backend - Engine

I added the requested docblocks. They don't seem to add any value over the stuff I'd already documented. The methods are self documenting. I'm literally just repeating what the method already says over and over again unless I'm missing something.

added 1 commit

0a443c1c - Refactor Boost Code - #1149

Compare with previous version

@markeharding Did I understand what we discussed about the counters correctly in this last change?

mentioned in issue #1134

@markeharding is going to re-review this and we'll get it merged in

assigned to @markeharding

My tests so far:

Boosts appear in rotator
Boosts appear in sidebar
Can create a newsfeed boost
Can create a sidebar boost
Can send a boost offer to another channel
Can receive and accept a boost offer from another channel

Awaiting @benhayward.ben response as boost offer was sent to him.

Creating a sidebar boost emits the following log notice, though it does complete successfully.

2019/12/06 00:32:28 [error] 8#8: *342 FastCGI sent in stderr: "PHP message: Attribute handler is not defined in Minds\Core\Boost\Network\Boost (getHandler)PHP message: Attribute handler is not defined in Minds\Core\Boost\Network\Boost (getHandler)PHP message: Attribute handler is not defined in Minds\Core\Boost\Network\Boost (getHandler)PHP message: Attribute handler is not defined in Minds\Core\Boost\Network\Boost (getHandler)" while reading response header from upstream, client: 192.168.13.110, server: _, request: "POST /api/v2/boost/user/996163850711601168/0 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "feat-1149-boost-refactor.minds.io", referrer: "https://feat-1149-boost-refactor.minds.io/newsfeed/subscriptions"

On first load, the GET request for the sidebar content emits the following:

2019/12/06 00:21:34 [error] 8#8: *15 FastCGI sent in stderr: "PHP message: Exception #1575591694: TypeError: Argument 1 passed to Minds\Core\Boost\Network\Iterator::setOffset() must be of the type int, string given, called in /var/www/Minds/engine/Controllers/api/v1/boost/fetch.php on line 58 and defined in /var/www/Minds/engine/Core/Boost/Network/Iterator.php:57
Stack trace:
#0 /var/www/Minds/engine/Controllers/api/v1/boost/fetch.php(58): Minds\Core\Boost\Network\Iterator->setOffset('')
#1 /var/www/Minds/engine/Api/Factory.php(87): Minds\Controllers\api\v1\boost\fetch->get(Array)
#2 /var/www/Minds/engine/Controllers/api/api.php(76): Minds\Api\Factory::build(Array, Object(Zend\Diactoros\ServerRequest), Object(Zend\Diactoros\Response\JsonResponse))
#3 /var/www/Minds/engine/Core/Router.php(157): Minds\Controllers\api\api->get(Array)
#4 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route()
#5 {main}" while reading response header from upstream, client: 192.168.13.110, server: _, request: "GET /api/v1/boost/fetch/content?limit=8&offset=&rating=2 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "feat-1149-boost-refactor.minds.io", referrer: "https://feat-1149-boost-refactor.minds.io/newsfeed/subscriptions"

added scoped label and automatically removed label

added 1 commit

cfe70dfa - Refactor Boost Code - #1149

Compare with previous version

Last fix for the sidebar content just causes the request to time out now.

2019/12/06 01:13:26 [error] 8#8: *111 upstream timed out (110: Operation timed out) while reading response header from upstream, client: 192.168.13.110, server: _, request: "GET /api/v1/boost/fetch/content?limit=8&offset=&rating=2 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "feat-1149-boost-refactor.minds.io", referrer: "https://feat-1149-boost-refactor.minds.io/newsfeed/subscriptions"

[06-Dec-2019 01:14:26] WARNING: [pool www] child 11, script '/var/www/Minds/engine/index.php' (request: "GET /index.php?limit=8&offset=&rating=2") execution timed out (120.331320 sec), terminating
[06-Dec-2019 01:14:26] WARNING: [pool www] child 11 exited on signal 15 (SIGTERM) after 397.361877 seconds from start

 <?php
 namespace Minds\Core\Boost;
 use Minds\Core\Data\cache\abstractCacher;
 use Minds\Core\Entities\Resolver;
 use Minds\Entities\User;
 use Minds\Core;
 use Minds\Helpers\Time;
 abstract class Feed