Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 296
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !407

Open
Opened 1 week ago by Emiliano Balbuena@edgebal
Report abuse

Top Algorithm

Testing

  • Check notes at front!677

Issues

  • Closes #1144
  • Closes #1145
  • Closes #1157
  • Closes #1174
  • Closes #1192
Edited 1 day ago by Emiliano Balbuena
Request to merge goal/top-algorithm-redux-2 into master
The source branch is 11 commits behind the target branch
Open in Web IDE
Pipeline #100986242 running for b8086ffe on goal/top-algorithm-redux-2
          Requires 3 more approvals from Devs, Deployers, and QA.
          Olivia Madrid
          Olivia Madrid
          Guy Thouret
          Guy Thouret
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          Rami Albatal
          Rami Albatal
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1144, #1145, #1157, #1174, and #1192

          Deletes source branch

          • Discussion 5
          • Commits 9
          • Pipelines 6
          • Changes 37
          2/3 threads resolved
          • Emiliano Balbuena @edgebal changed milestone to %HILE Q4/2019 1 week ago

            changed milestone to %HILE Q4/2019

          • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 1 week ago

            added scoped label

          • Emiliano Balbuena @edgebal added 1 commit 1 week ago

            added 1 commit

            • 129b4263 - (cs): Lint

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
            Resolved by Emiliano Balbuena 3 days ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
            Resolved by Emiliano Balbuena 3 days ago
          • Mark Harding @markeharding added MR::Requires Changes scoped label 3 days ago

            added scoped label

          • Emiliano Balbuena @edgebal added 9 commits 3 days ago

            added 9 commits

            • 129b4263...1359daf0 - 7 commits from branch master
            • fef9ec65 - Merge remote-tracking branch 'origin/master' into goal/top-algorithm-redux-2
            • 1bc10ba7 - (chore): Use StaticToInstance; add secsAgo to sync CLI

            Compare with previous version

          • Emiliano Balbuena @edgebal resolved all threads 3 days ago

            resolved all threads

          • Emiliano Balbuena @edgebal added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 days ago

            added scoped label and automatically removed label

          • Emiliano Balbuena @edgebal mentioned in merge request !186 (closed) 3 days ago

            mentioned in merge request !186 (closed)

          • Emiliano Balbuena @edgebal added 1 commit 2 days ago

            added 1 commit

            • 22dce1e1 - (feat): Fallback to other periods on /api/v2/feeds/global

            Compare with previous version

          • Emiliano Balbuena @edgebal added 2 commits 2 days ago

            added 2 commits

            • 314531ef - (refactor): Use Response to stack period fallbacks
            • 0ed3b3bd - (chore): Check for period_callback query param

            Compare with previous version

          • Emiliano Balbuena @edgebal changed the description 2 days ago

            changed the description

          • Emiliano Balbuena @edgebal changed the description 1 day ago

            changed the description

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

            approved this merge request

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
            Developer

            Backend works without issue, but there's a front end weirdness I reported over there.

          • Mark Harding
            Mark Harding @markeharding · 45 minutes ago
            Owner

            Looks to be an issue with:

            • Channels
            • Groups
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 45 minutes ago

            added scoped label and automatically removed label

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 42 minutes ago
            Controllers/api/v2/feeds.php
            185 199 }
            186 200
            187 201 try {
            188 $result = $manager->getList($opts);
            202 $entities = new Response();
            203 $fallbackAt = null;
            204 $i = 0;
            205
            206 while ($entities->count() < $limit) {
            • Mark Harding
              Mark Harding @markeharding · 42 minutes ago
              Owner

              This is a lot of logic going on in an untestable controller. If we have time it would be good to refactor into Core/Feeds/FeedCollection or something

            • Please register or sign in to reply
          • Emiliano Balbuena @edgebal added 1 commit 2 minutes ago

            added 1 commit

            • b8086ffe - (chore): Disable timestamp constrain on old algorithms

            Compare with previous version

          Please register or sign in to reply
          Assignee
          Emiliano Balbuena's avatar
          Emiliano Balbuena @edgebal
          HILE Q4/2019
          Milestone
          HILE Q4/2019
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Olivia Madrid
          user avatar
          Guy Thouret
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          user avatar
          Rami Albatal
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          Reference: minds/engine!407