Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 397
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !677

Open
Opened 2 days ago by Emiliano Balbuena@edgebal
Report abuse

Allow period fallbacks on Discovery feeds

Testing

  • Go to https://goal-top-algorithm-redux-2.minds.io/newsfeed/global/top;period=12h
  • Check that the Posts older than 12H legend appears at some point, with older posts below
  • Play around with TOP and LATEST filters.

Note: Do not use HOT as it's running on the old votes-per-period system which isn't running on Sandboxes.

Note 2: The only updated list on that sandbox site is the activity one. Discovery for Images/Videos/Blogs might appear empty.

Devs: Refreshing Top posts list

  • Switch to Sandbox cluster
  • $ kubectl get pods | grep goal-top-algorithm-redux-2-minds-app
  • $ kubectl exec -ti goal-top-algorithm-redux-2-minds-app-{random_ID_HERE} sh
  • $ cd /var/www/Minds/engine
  • $ php cli.php top all sync_activity --metric=up --from=1 && php cli.php top all sync_activity --metric=down --from=1

Issues

  • Closes #2269
Edited 1 day ago by Emiliano Balbuena
Request to merge goal/top-algorithm-redux-2 into master
The source branch is 1 commit behind the target branch
Open in Web IDE
Pipeline #100378834 passed with warnings for 768c7a5f on goal/top-algorithm-redux-2
              Requires approval from QA. Approved by
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Marcelo Rivera
              Marcelo Rivera
              Ben Hayward
              Ben Hayward
              Depends on 1 merge request being merged
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2269

              Deletes source branch

              • Discussion 3
              • Commits 3
              • Pipelines 3
              • Changes 5
              0/1 thread resolved
              • Emiliano Balbuena @edgebal added MR::Awaiting Review Squad::Yellow scoped labels 2 days ago

                added scoped labels

              • Emiliano Balbuena @edgebal changed milestone to %HILE Q4/2019 2 days ago

                changed milestone to %HILE Q4/2019

              • Emiliano Balbuena @edgebal added 1 commit 2 days ago

                added 1 commit

                • 637b88fb - (fix): Misaligned margin

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 day ago

                added 1 commit

                • 768c7a5f - (chore): Enable 1Y back

                Compare with previous version

              • Emiliano Balbuena @edgebal changed the description 1 day ago

                changed the description

              • Emiliano Balbuena @edgebal mentioned in merge request engine!407 1 day ago

                mentioned in merge request engine!407

                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 1 day ago
                  Developer

                  There's something funky up with the feed selectors.

                  When I hit this, with the query parameters, it works.

                  https://goal-top-algorithm-redux-2.minds.io/newsfeed/global/top;period=12h;all=1

                  When you navigate back to newsfeed and then back, however, you get nothing

                  Screen capture here https://www.screencast.com/t/G96AUFdUby

                  Edited by Brian Hatchet 12 minutes ago
                • Collapse replies
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 12 minutes ago
                  Developer

                  @edgebal pointed out that the preferred filter gets set to On when switching to discovery tab. It's not an issue for this card.

                • Please register or sign in to reply
              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 10 minutes ago

                approved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 10 minutes ago
                Developer

                @xander-miller Can you review this MR?

              Please register or sign in to reply
              Assignee
              Emiliano Balbuena's avatar
              Emiliano Balbuena @edgebal
              HILE Q4/2019
              Milestone
              HILE Q4/2019
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              user avatar
              Ben Hayward
              user avatar
              Rami Albatal
              user avatar
              Mark Harding
              Reference: minds/front!677