Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 396
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !613

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936

Closes #1936

Depends on engine!384

Summary

This change moves future blogs and media posts from the mature blog system, to the NSFW blog system. When creating a new blog. When editing existing values must be shown.

  • The selection should propagate to the media entity.
  • Changes via edit should also propegate

Testing

  1. Make video post with NSFW
  2. Edit the activity and change the NSFW tags to other, so that the mask goes away
  3. Refresh, see no mask
  4. Go to the media page for the actiity, and edit to Pornography.
  5. Checking back widgets, activity and blog post should have updated with flag.

Repeat for posting standard text posts, images and blogs.

Issues I'm aware of

  • The pre-existing value for the NSFW selector is not respected, it must be clicked before it will register something as NSFW.
  • Live update of NSFW in sidebar widgets - I would prefer to leave this out of this, and add that in at a later date. With the amount of testing involved change-detection fixes are not something I want to add into the mix.
  • Image posts are not propagating to sidebar widget; handled here engine#1150 Blogs and Video should be
  • Comments are still on the mature system - that is out of scope of this change.
Edited 19 minutes ago by Ben Hayward
Request to merge fix/blog-media-nsfw-update-1936 into master
The source branch is 37 commits behind the target branch
Open in Web IDE
Pipeline #100742919 passed with warnings for 90ceb322 on fix/blog-media-nsfw-update-1936
              Requires 3 more approvals from Devs, Deployers, and QA.
              Juan Manuel Solaro
              Juan Manuel Solaro
              Marcelo Rivera
              Marcelo Rivera
              Guy Thouret
              Guy Thouret
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1936

              Mentions engine#1150

              Deletes source branch

              • Discussion 12
              • Commits 18
              • Pipelines 10
              • Changes 9
              7/7 threads resolved
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 month ago

                added scoped labels

              • Ben Hayward @benhayward.ben changed the description 1 month ago

                changed the description

              • Ben Hayward @benhayward.ben marked as a Work In Progress 1 month ago

                marked as a Work In Progress

              • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 month ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben mentioned in merge request engine!384 1 month ago

                mentioned in merge request engine!384

              • Ben Hayward @benhayward.ben changed the description 1 month ago

                changed the description

              • Ben Hayward @benhayward.ben added 2 commits 1 month ago

                added 2 commits

                • b3bf6a83 - Updated test
                • be7434a2 - Updated E2E tests to use newer nsfw selector

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 weeks ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben unmarked as a Work In Progress 3 weeks ago

                unmarked as a Work In Progress

              • Ben Hayward @benhayward.ben added 90 commits 2 weeks ago

                added 90 commits

                • be7434a2...a0d1737e - 87 commits from branch master
                • 7cb030ad - Merge branch 'master' of gitlab.com:minds/front into fix/blog-media-nsfw-update-1936
                • aaf95d86 - Merge branch 'master' of gitlab.com:minds/front into fix/blog-media-nsfw-update-1936
                • 76664e6c - Merge branch 'master' of gitlab.com:minds/front into fix/blog-media-nsfw-update-1936

                Compare with previous version

                Toggle commit list
              • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 weeks ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben marked as a Work In Progress 2 weeks ago

                marked as a Work In Progress

              • Ben Hayward @benhayward.ben changed the description 2 weeks ago

                changed the description

              • Ben Hayward @benhayward.ben changed the description 2 weeks ago

                changed the description

              • Ben Hayward @benhayward.ben added 2 commits 2 weeks ago

                added 2 commits

                • f91890c3 - Blogs working correctly
                • 36f95435 - spec test fix

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 2 weeks ago

                changed the description

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 week ago
                Developer

                This definitely needs testing with live data, so we can see how old blogs marked as mature will react to the changes.

              • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                added 1 commit

                • 31888535 - Removed console logs

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 1 week ago

                changed the description

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben unmarked as a Work In Progress 1 week ago

                unmarked as a Work In Progress

              • Xander Miller @xander-miller approved this merge request 1 week ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet added version::3.12.0 scoped label 2 days ago

                added scoped label

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 day ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 day ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 day ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 day ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 day ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 18 minutes ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 18 minutes ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 days ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 3 commits 1 day ago

                added 3 commits

                • 4e45bed1 - Updated for feedback
                • 96815b9d - Redundant code
                • 406c3cc3 - Update for feedback

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • d3605f04 - Update for feedback

                Compare with previous version

              • Ben Hayward @benhayward.ben added 2 commits 1 day ago

                added 2 commits

                • 041ce622 - Updated nsfw selector
                • 455caa81 - Minor changes

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 23 hours ago

                changed the description

              • Ben Hayward @benhayward.ben added 1 commit 1 hour ago

                added 1 commit

                • 90ceb322 - Arbitrary commit (full stop)

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 23 minutes ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben changed the description 19 minutes ago

                changed the description

              • Ben Hayward @benhayward.ben resolved all threads 18 minutes ago

                resolved all threads

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              3
              Labels
              MR::Awaiting Review Squad::Yellow version::3.12.0
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Mark Harding
              user avatar
              Xander Miller
              user avatar
              Rami Albatal
              Reference: minds/front!613