[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936
Closes front#1936
Depends on front!613
Testing
Go to a blog, make it nsfw. Upload an image, click it, edit - make that nsfw too.
Check that when you open them they are NSFW. They will likely not be NSFW on feeds due to #1043
This needs repeating for images, video, reminds, in groups etc (have all worked for me)
added scoped labels
changed the description
mentioned in merge request front!613
added 6 commits
-
c58d6ffc...4d188166 - 4 commits from branch
master - 14a2be02 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
- 1825a459 - Blog to activity propegation fix.
-
c58d6ffc...4d188166 - 4 commits from branch
marked as a Work In Progress
added scoped label and automatically removed label
unmarked as a Work In Progress
changed the description
added scoped label and automatically removed label
added scoped label and automatically removed label
added scoped label and automatically removed label
assigned to @xander-miller
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Owner@xander-miller please give approval when you are happy with this.
approved this merge request
unapproved this merge request
approved this merge request
approved this merge request
- Owner
I am unable to test as I have a 500 error.
[19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "NOTICE: PHP message: Exception #1574156970: Error: Call to a member function getContext() on boolean in /var/www/Minds/front/dist/en/index.php:4" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "Stack trace:" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#0 /var/www/Minds/engine/Core/I18n/I18n.php(123): include()" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#1 /var/www/Minds/engine/Core/Router.php(166): Minds\Core\I18n\I18n->serveIndex()" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#2 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route()" [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#3 {main}" 127.0.0.1 - 19/Nov/2019:09:49:30 +0000 "GET /index.php" 500 - Developer
This was a sandbox issue that got sorted out.
added scoped label and automatically removed label
added 61 commits
-
7c02251e...52a592b9 - 59 commits from branch
master - 7cedf6a3 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
- cf9b88dc - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
-
7c02251e...52a592b9 - 59 commits from branch
- Developer
Pulled in master, should reset the backend and resolve that.
![Xander Miller](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
Developer@markeharding test sandbox is back up. You can try reviewing again.
added 1 commit
- 4f78a38e - Updated to support old-style mature flagged blogs
added scoped label and automatically removed label
approved this merge request
- Developer
I tested this with Ben's latest changes and am pleased to report it works. I can edit a blog, mark it NSFW and have it propagate changes. On Monday, we'll get it up on of the Beatles servers and give it a proper test with live data.
approved this merge request
- Developer
Hi @markeharding, during yellow squad meeting today, we heard you have some concerns about the NSFW changes. I think that is in reference to this merge request. Could you add some review notes so we know what to fix / look out for when testing?
- Last updated by Ben Hayward
295 299 296 300 if ($field == 'access_id') { 297 301 $data[$field] = (int) $data[$field]; 302 } elseif ($field == 'nsfw') { - Owner
classes\ElggEntity:L1558handles the NSFW validation checking. Why is a JSON object being provided? Currently any values could be set here. changed this line in version 12 of the diff
- Resolved by Ben Hayward
- Resolved by Ben Hayward
added scoped label and automatically removed label
added 35 commits
-
4f78a38e...4fb65001 - 34 commits from branch
master - ba297a25 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
-
4f78a38e...4fb65001 - 34 commits from branch
- Resolved by Brian Hatchet
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Last updated by Ben Hayward
502 502 } 503 503 } 504 504 $this->nsfw = $array; 505 $this->markAsDirty('nsfw'); - Developer
I am pretty sure this gets set automatically when you call an attribute on a blog, but double check
- Developer
If you check in the legacy blog repository you can log the fields that are about to get written. Those should be set already
Blogs/Legacy/Repository.php ~L216
- Developer
On initial save it does, but on blog edit, the attribute needs to be marked as dirty or it does not show
- Last updated by Ben Hayward
60 60 ->setThumbnail($blog->getIconUrl()) 61 61 ->setFromEntity($blog) 62 62 ->setMature($blog->isMature()) 63 ->setNsfw($blog->getNsfw()) - Developer
Double check to make sure that we are not handling this in propegate
- Developer
Have double checked, not handled by propegateProperties though a fair thing to check.
- Resolved by Ben Hayward
added 5 commits
-
587ee91b...fa6047ce - 4 commits from branch
master - 3af064a0 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
-
587ee91b...fa6047ce - 4 commits from branch
![:speech_balloon:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":speech_balloon:"){kind=small}
