Port Boost Refactors onto existing Boost code
Is this a bug? Make sure to use the Bug template above and be as detailed in your report as possible.
added scoped label
added scoped label
added scoped label
added scoped label
added scoped label
added scoped label
added scoped label and automatically removed label
![Guy Thouret](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Developer- Developer
203 commits diverge from master and will need to be squashed
changed milestone to %Boost Refactor #mvp
changed time estimate to 2d
added 1d of time spent at 2019-11-26
- Developer
Couple of issues to resolve:
2019/11/27 13:57:40 [error] 8#8: *17 FastCGI sent in stderr: "PHP message: [CQL Error: Cassandra\Exception\InvalidQueryException] Key may not be emptyPHP message: {"string":"SELECT count FROM counters WHERE guid = ? AND metric = ?","values":["","boost_impressions"]}" while reading response header from upstream, client: 192.168.13.110, server: _, request: "GET /api/v2/boost/newsfeed/?limit=12&offset= HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "feat-1149-boost-refactor.minds.io", referrer: "https://feat-1149-boost-refactor.minds.io/boost/console/newsfeed/history" - Developer
2019/11/27 13:56:11 [error] 8#8: *6 FastCGI sent in stderr: "PHP message: Attribute rejectReason is not defined in Minds\Core\Boost\Network\Boost (setRejectReason)PHP message: Exception #1574862970: Error: Call to a member function incrementViews() on bool in /var/www/Minds/engine/Controllers/api/v2/analytics/views.php:40 Stack trace: #0 /var/www/Minds/engine/Api/Factory.php(87): Minds\Controllers\api\v2\analytics\views->post(Array) #1 /var/www/Minds/engine/Controllers/api/api.php(81): Minds\Api\Factory::build(Array, Object(Zend\Diactoros\ServerRequest), Object(Zend\Diactoros\Response\JsonResponse)) #2 /var/www/Minds/engine/Core/Router.php(157): Minds\Controllers\api\api->post(Array) #3 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route() #4 {main}" while reading response header from upstream, client: 192.168.13.110, server: _, request: "POST /api/v2/analytics/views/boost/998658547002642441 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "feat-1149-boost-refactor.minds.io", referrer: "https://feat-1149-boost-refactor.minds.io/newsfeed/subscriptions" added scoped label and automatically removed label
mentioned in merge request !409 (closed)
created merge request !409 (closed) to address this issue
added 3d of time spent at 2019-12-02
- Developer
Getting a 500 on
api/v1/boost/fetch/content?limit=8&offset=&rating=2 added scoped label and automatically removed label
added scoped label and automatically removed label
- Developer
2019/12/02 16:01:27 [error] 8#8: *323 FastCGI sent in stderr: "PHP message: Attribute rejectReason is not defined in Minds\Core\Boost\Network\Boost (setRejectReason)PHP message: Exception #1575302487: Error: Call to a member function incrementViews() on bool in /var/www/Minds/engine/Controllers/api/v2/analytics/views.php:40 Stack trace: #0 /var/www/Minds/engine/Api/Factory.php(87): Minds\Controllers\api\v2\analytics\views->post(Array) #1 /var/www/Minds/engine/Controllers/api/api.php(81): Minds\Api\Factory::build(Array, Object(Zend\Diactoros\ServerRequest), Object(Zend\Diactoros\Response\JsonResponse)) #2 /var/www/Minds/engine/Core/Router.php(157): Minds\Controllers\api\api->post(Array) #3 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route() #4 {main}" while reading response header from upstream, client: 192.168.13.110, server: _, request: "POST /api/v2/analytics/views/boost/1005588450394509314 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "feat-1149-boost-refactor.minds.io", referrer: "https://feat-1149-boost-refactor.minds.io/newsfeed/subscriptions" added 1h of time spent at 2019-12-04
DeveloperJust need to get the associated MR reviewed and we can get it merged in.
