3/5
threads resolved
changed milestone to %Boost Refactor #mvp
added scoped labels
unmarked as a Work In Progress
- Last updated by Guy Thouret
1 <?php 2 3 namespace Minds\Core\Boost; 4 5 use Minds\Core\Data\cache\abstractCacher; 6 use Minds\Core\Entities\Resolver; 7 use Minds\Entities\User; 8 use Minds\Core; 9 use Minds\Helpers\Time; 10 11 abstract class Feed - Owner
rename to AbstractFeed
- Developer
That's not a naming convention I've ever seen/used before. Any reason for that?
- Resolved by Guy Thouret
- Resolved by Guy Thouret
- Resolved by Guy Thouret
447 424 $export = array_merge($export, \Minds\Core\Events\Dispatcher::trigger('export:extender', 'all', ['entity' => $this], [])); 448 425 $export = \Minds\Helpers\Export::sanitize($export); 449 426 450 $export['met_impressions'] = Counters::get((string) $this->getId(), "boost_impressions") - Owner
We need to confirm if this is going to break counters pre-elasticsearch migration.
- Developer
I added the requested docblocks. They don't seem to add any value over the stuff I'd already documented. The methods are self documenting. I'm literally just repeating what the method already says over and over again unless I'm missing something.
- Developer
@markeharding Did I understand what we discussed about the counters correctly in this last change?