Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 293
  • Merge Requests 40
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !410

Open
Opened 6 days ago by Guy Thouret@gthouret
Report abuse

Refactor Boost Code

Closes #1149

Edited 1 day ago by Guy Thouret
Request to merge feat/1149-boost-refactor into master
The source branch is 12 commits behind the target branch
Open in Web IDE
Pipeline #100589276 passed for 0a443c1c on feat/1149-boost-refactor
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Olivia Madrid
          Olivia Madrid
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1149

          • Discussion 8
          • Commits 1
          • Pipelines 7
          • Changes 54
          3/5 threads resolved
          • Guy Thouret @gthouret changed milestone to %Boost Refactor #mvp 6 days ago

            changed milestone to %Boost Refactor #mvp

          • Guy Thouret @gthouret added MR::Awaiting Review Squad::Blue scoped labels 6 days ago

            added scoped labels

          • Guy Thouret @gthouret added 1 commit 2 days ago

            added 1 commit

            • cd72577e - Refactor Boost Code - #1149

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 2 days ago

            added 1 commit

            • e7269ef5 - Refactor Boost Code - #1149

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 day ago

            added 1 commit

            • 6efd9e52 - Refactor Boost Code - #1149

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 day ago

            added 1 commit

            • 722e6865 - Refactor Boost Code - #1149

            Compare with previous version

          • Guy Thouret @gthouret unmarked as a Work In Progress 1 day ago

            unmarked as a Work In Progress

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 18 hours ago
            Last updated by Guy Thouret 3 hours ago
            Core/Boost/Feed.php
            1 <?php
            2
            3 namespace Minds\Core\Boost;
            4
            5 use Minds\Core\Data\cache\abstractCacher;
            6 use Minds\Core\Entities\Resolver;
            7 use Minds\Entities\User;
            8 use Minds\Core;
            9 use Minds\Helpers\Time;
            10
            11 abstract class Feed
            • Mark Harding
              Mark Harding @markeharding · 18 hours ago
              Owner

              rename to AbstractFeed

            • Guy Thouret
              Guy Thouret @gthouret · 3 hours ago
              Developer

              That's not a naming convention I've ever seen/used before. Any reason for that?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 18 hours ago
            Resolved by Guy Thouret 2 hours ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 18 hours ago
            Resolved by Guy Thouret 2 hours ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 18 hours ago
            Resolved by Guy Thouret 2 hours ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 18 hours ago
            Entities/Boost/Network.php
            447 424 $export = array_merge($export, \Minds\Core\Events\Dispatcher::trigger('export:extender', 'all', ['entity' => $this], []));
            448 425 $export = \Minds\Helpers\Export::sanitize($export);
            449 426
            450 $export['met_impressions'] = Counters::get((string) $this->getId(), "boost_impressions")
            • Mark Harding
              Mark Harding @markeharding · 18 hours ago
              Owner

              We need to confirm if this is going to break counters pre-elasticsearch migration.

            • Please register or sign in to reply
          • Guy Thouret @gthouret added 1 commit 2 hours ago

            added 1 commit

            • e131e830 - Refactor Boost Code - #1149

            Compare with previous version

          • Guy Thouret
            Guy Thouret @gthouret · 2 hours ago
            Developer

            I added the requested docblocks. They don't seem to add any value over the stuff I'd already documented. The methods are self documenting. I'm literally just repeating what the method already says over and over again unless I'm missing something.

          • Guy Thouret @gthouret added 1 commit 2 hours ago

            added 1 commit

            • 0a443c1c - Refactor Boost Code - #1149

            Compare with previous version

          • Guy Thouret
            Guy Thouret @gthouret · 2 hours ago
            Developer

            @markeharding Did I understand what we discussed about the counters correctly in this last change?

          • Guy Thouret @gthouret mentioned in issue #1134 1 hour ago

            mentioned in issue #1134

          Please register or sign in to reply
          0 Assignees
          None
          Boost Refactor #mvp
          Milestone
          Boost Refactor #mvp
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Blue
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          user avatar
          Rami Albatal
          user avatar
          Olivia Madrid
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          Reference: minds/engine!410