Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 293
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #1077

Closed
Open
Opened 1 month ago by Guy Thouret@gthouret
Report abuse New issue

Extract the logic that records views out of the View API

The functionality that verifies and records a view for a boost (and then triggers lifecycle events) is hidden away inside v2/analytics/views api controller alongside the functionality for recording entity/activity views. This boost functionality needs to be extracted and implemented within Core\Boost namespace with either a common View interface or extending a View abstract and then implement the concrete boost view functionality.

Edited 1 month ago by Guy Thouret

Related issues
0

Related merge requests
1
  • WIP: Extract record view details from analytics/views api call
    !413
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 4
  • Designs 0
  • Guy Thouret @gthouret added Sprint::10/23 - Quiet Quail scoped label 1 month ago

    added scoped label

  • Guy Thouret @gthouret changed weight to 3 1 month ago

    changed weight to 3

  • Guy Thouret @gthouret assigned to @gthouret 1 month ago

    assigned to @gthouret

  • Guy Thouret @gthouret added Type::Refactor scoped label 1 month ago

    added scoped label

  • Guy Thouret @gthouret added Squad::Blue scoped label 1 month ago

    added scoped label

  • Guy Thouret @gthouret added Status::Backlog scoped label 1 month ago

    added scoped label

  • Guy Thouret @gthouret changed the description 1 month ago

    changed the description

  • Guy Thouret @gthouret changed time estimate to 4h 1 month ago

    changed time estimate to 4h

  • Mark Harding @markeharding added Sprint::11/06 - Rolling Rabbit scoped label and automatically removed Sprint::10/23 - Quiet Quail label 3 weeks ago

    added scoped label and automatically removed label

  • Mark Harding
    Mark Harding @markeharding · 3 weeks ago
    Owner

    Are we still planning on storing in the views table?

  • Mark Harding @markeharding added Status::Review scoped label and automatically removed Status::Backlog label 3 weeks ago

    added scoped label and automatically removed label

  • Mark Harding @markeharding removed Status::Review label 3 weeks ago

    removed label

  • Guy Thouret @gthouret added to epic &103 3 weeks ago

    added to epic &103

  • Mark Harding @markeharding added Sprint::11/20 - Silly Sheep scoped label and automatically removed Sprint::11/06 - Rolling Rabbit label 1 week ago

    added scoped label and automatically removed label

  • Guy Thouret @gthouret added Priority::3 - Nice to have scoped label 1 week ago

    added scoped label

  • Guy Thouret @gthouret added Status::InProgress scoped label 6 days ago

    added scoped label

  • Guy Thouret @gthouret removed Status::InProgress label 1 day ago

    removed label

  • Guy Thouret @gthouret added Status::InProgress scoped label 14 hours ago

    added scoped label

  • Guy Thouret @gthouret added 1h of time spent at 2019-12-03 9 hours ago

    added 1h of time spent at 2019-12-03

  • Guy Thouret @gthouret mentioned in commit 3200ea77 9 hours ago

    mentioned in commit 3200ea77

  • Guy Thouret
    Guy Thouret @gthouret · 1 hour ago
    Developer

    Pushed branch with an incompatible name so pipelines failed. Renamed to extract-view-api-1077

  • Guy Thouret
    Guy Thouret @gthouret · 1 hour ago
    Developer

    Just need to attempt to add Spec test for the Views if that is possible -singleton usage of Core\Analytics\App::_() might make spec test not possible.

  • Guy Thouret @gthouret mentioned in merge request !413 31 minutes ago

    mentioned in merge request !413

  • Guy Thouret
    Guy Thouret @gthouret · 31 minutes ago
    Developer

    Errors already...

    019/12/03 23:50:11 [error] 8#8: *1 FastCGI sent in stderr: "PHP message: Exception #1575417011: Error: Call to a member function record() on null in /var/www/Minds/engine/Core/Analytics/Views/Record.php:126
    Stack trace:
    #0 /var/www/Minds/engine/Controllers/api/v2/analytics/views.php(37): Minds\Core\Analytics\Views\Record->recordEntity()
    #1 /var/www/Minds/engine/Api/Factory.php(87): Minds\Controllers\api\v2\analytics\views->post(Array)
    #2 /var/www/Minds/engine/Controllers/api/api.php(81): Minds\Api\Factory::build(Array, Object(Zend\Diactoros\ServerRequest), Object(Zend\Diactoros\Response\JsonResponse))
    #3 /var/www/Minds/engine/Core/Router.php(157): Minds\Controllers\api\api->post(Array)
    #4 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route()
    #5 {main}" while reading response header from upstream, client: 192.168.13.110, server: _, request: "POST /api/v2/analytics/views/activity/1041765287684214800 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "extract-view-api-1077.minds.io", referrer: "https://extract-view-api-1077.minds.io/newsfeed/subscriptions"
Please register or sign in to reply
Assignee
Guy Thouret's avatar
Guy Thouret @gthouret
Boost Backend Improvements
Epic
Boost Backend Improvements
None
Milestone
None
Time tracking
Spent 1h
Est 4h
None
Due date
None
5
Labels
Priority::3 - Nice to have Sprint::11/20 - Silly Sheep Squad::Blue Status::InProgress Type::Refactor
3
Weight
3
Confidentiality
Not confidential
Lock issue
Unlocked
2
2 participants
user avatar
Guy Thouret
user avatar
Mark Harding
Reference: minds/engine#1077