[Sprint/SillySheep](fix): Failing spam detection on staging causing issues when uploading media #1193
Closes #1193 (closed)
Summary
Following an update to the spam detection system, videos stopped working because the spam detector was expecting an Entity object rather than the Video that our media POST was passing to it. The same applies to an Image object being passed through.
This caused an issue where-in ->getDescription() could not be found - as Video has the description attribute, I added getters and setters into the Video and Image classes.
Testing
Test various upload types, try posting with and without a red flag failing link (e.g. bit.ly).
added scoped labels
added scoped label and automatically removed label
added 1 commit
- 27039ee4 - Added description getter and setters for images
changed title from : Failing spam detection media to : Failing spam detection media
changed the description
added scoped label and automatically removed label
approved this merge request
DeveloperFeels like there is a couple hundred milliseconds of lag at the end of the progress bar just before a image uploads but seems more stable than previously.
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Resolved by Ben Hayward- Resolved by Ben Hayward
added scoped label and automatically removed label
- Owner
We need to use method_exists on https://gitlab.com/minds/engine/blob/master/Core/Security/Spam.php#L32
resolved all threads
added scoped labels
approved this merge request
added scoped label and automatically removed label
mentioned in commit 4fb65001
merged
