Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 301
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !412

Open
Opened 36 minutes ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/SillySheep](fix): Failing spam detection causing issues when uploading webm media #1193

Closes #1193

Summary

Following an update to the spam detection system, videos stopped working because the spam detector was expecting an Entity object rather than the Video that our media POST was passing to it.

This caused an issue where-in ->getDescription() could not be found - as Video has the description attribute, I added getters and setters into the Video class.

Testing

Test various upload types, try posting with and without a red flag failing link (e.g. bit.ly).

Request to merge fix/spam-detection-webm-1193 into master
Open in Web IDE
Pipeline #100320140 passed for 4ba8807f on fix/spam-detection-webm-1193
          Requires 3 more approvals from Devs, Deployers, and QA.
          Marcelo Rivera
          Marcelo Rivera
          Olivia Madrid
          Olivia Madrid
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1193

          Deletes source branch

          • Discussion 0
          • Commits 3
          • Pipelines 3
          • Changes 2
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 36 minutes ago

            added scoped labels

          • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 25 minutes ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 22 minutes ago

            added 1 commit

            • 27039ee4 - Added description getter and setters for images

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 21 minutes ago

            added 1 commit

            • 4ba8807f - Forgot to switch return type

            Compare with previous version

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Marcelo Rivera
          user avatar
          Olivia Madrid
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Guy Thouret
          user avatar
          Martin Santangelo
          Reference: minds/engine!412